Skip to content

SkriptEvent - Since array support #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
APickledWalrus merged 18 commits into from
Jul 1, 2025
Merged

SkriptEvent - Since array support #7706

APickledWalrus merged 18 commits into from
Jul 1, 2025

Conversation

@Fusezion
Copy link
Contributor

@Fusezion Fusezion commented Mar 16, 2025 •
edited
Loading

Description

This PR aims to support since as an array on skript events, I would need some help getting a local version up for ensuring html is loading correct, I've confirmed that the json does work as expected. However html requires a template which I do not have nor can I find.

The PR was based off of how the since annotation was implemented so long as that had no issues I'm not expecting any here either.

Target Minecraft Versions: any
Requirements: none
Related Issues: #7590

@Fusezion Fusezion changed the title SkriptEvent - Since array suipport (DRAFT) SkriptEvent - Since array support (DRAFT) Mar 16, 2025
@Fusezion Fusezion mentioned this pull request Mar 16, 2025
Open
4 tasks
@Efnilite Efnilite added enhancement Feature request, an issue about something that could be improved, or a PR improving something. breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) labels Mar 16, 2025
@Absolutionism
Copy link
Contributor

Absolutionism commented Mar 27, 2025

Maybe this can come out of draft? Considering none of the team members has yet to review it or point out anything that may or may not be flawed.

@Fusezion
Copy link
Contributor Author

Fusezion commented Mar 27, 2025

Maybe this can come out of draft? Considering none of the team members has yet to review it or point out anything that may or may not be flawed.

I probably could yeah, still needing to figure out how to get the template for loading the html

@Fusezion Fusezion marked this pull request as ready for review March 27, 2025 18:42
@Absolutionism
Copy link
Contributor

Absolutionism commented Mar 27, 2025

Pssss, Fuse, rename title

@Fusezion Fusezion changed the title SkriptEvent - Since array support (DRAFT) SkriptEvent - Since array support Mar 27, 2025
@APickledWalrus
Copy link
Member

APickledWalrus commented Apr 1, 2025

Is this breaking for addons (or does it require them to be recompiled) due to the method signature changes? E.g. how does an addon like SkBee load up with this?

@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label May 15, 2025
@sovdeeth
Copy link
Member

sovdeeth commented May 19, 2025

Is this breaking for addons (or does it require them to be recompiled) due to the method signature changes? E.g. how does an addon like SkBee load up with this?

@Fusezion

@Fusezion
Copy link
Contributor Author

Fusezion commented May 19, 2025

Is this breaking for addons (or does it require them to be recompiled) due to the method signature changes? E.g. how does an addon like SkBee load up with this?

From my understanding this would be a signature change, I could probably fix it with deprecation of original method, I based this off of original array support for @Since but since there's possibility in a deprecation period instead I could add a new method.

For addons this at most might just force them to compile against whatever version this is added in but things like SkriptHubDocsTool it is a breaking change around the board as the get method will return an array regardless

sovdeeth
sovdeeth approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, though maintaining the since(String) method as deprecated for backcompat would be preferred imo

@sovdeeth sovdeeth moved this to Needs Reviews in 2.12 Releases Jun 3, 2025
@APickledWalrus APickledWalrus linked an issue Jun 4, 2025 that may be closed by this pull request
Add string array support to SkriptEvent and ClassInfo since methods #7590
Open
4 tasks
APickledWalrus
APickledWalrus requested changes Jun 30, 2025
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just about ready

@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jun 30, 2025
Fusezion and others added 3 commits June 30, 2025 10:51
@Fusezion @APickledWalrus
Apply suggestions from code review
504a715 
I'll look into the last one here shortly

Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
@Fusezion
Merge remote-tracking branch 'upstream/dev/feature' into enhancement/…
7b71c00 
…event-since-array-support
@Fusezion
Make since an immutablelist
7e98642
APickledWalrus
APickledWalrus approved these changes Jun 30, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.12 Releases Jun 30, 2025
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jun 30, 2025
@APickledWalrus APickledWalrus removed a link to an issue Jul 1, 2025
Add string array support to SkriptEvent and ClassInfo since methods #7590
Open
4 tasks
@APickledWalrus APickledWalrus merged commit b16480f into SkriptLang:dev/feature Jul 1, 2025
5 checks passed
@skriptlang-automation skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jul 1, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in 2.12 Releases Jul 1, 2025
@skriptlang-automation skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jul 1, 2025
Burbulinis pushed a commit to Burbulinis/Skript that referenced this pull request Jul 9, 2025
@Fusezion @Burbulinis
SkriptEvent - Since array support (SkriptLang#7706)
cf60b0a
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
@Fusezion @erenkarakal
SkriptEvent - Since array support (SkriptLang#7706)
a9905ac
@Fusezion Fusezion deleted the enhancement/event-since-array-support branch December 15, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Pikachu920 Pikachu920 Awaiting requested review from Pikachu920

@AyhamAl-Ali AyhamAl-Ali Awaiting requested review from AyhamAl-Ali

@Efnilite Efnilite Awaiting requested review from Efnilite

Assignees

No one assigned

Labels

breaking changes Pull or feature requests that contain breaking changes (API, syntax, etc.) completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Projects

No open projects
2.12 Releases
Status: Done - Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Fusezion @Absolutionism @APickledWalrus @sovdeeth @Efnilite