ItemData - dont set damage if the item isnt damaged #7688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
approved these changes
Mar 8, 2025
Efnilite
added
the
bug
|
I do fear this doesn't solve anything if the source item is damaged, it just solves it for undamaged items |
sovdeeth
approved these changes
Mar 8, 2025
There was a problem hiding this comment.
further confirmation that it doesn't affect existing behavior here
https://discord.com/channels/988998880794402856/989227647060041780/1348037377427243093
Absolutionism
approved these changes
Mar 8, 2025
Efnilite
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix an issue where
type of %itemtype%adds a damage tag to non-damageable items.(See #7687 for the full story)
Target Minecraft Versions: any
Requirements: none
Related Issues: #7687