-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EffSendTitle and EffActionBar object support #7563
base: dev/feature
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few coding conventions
Also
|
What other way to send an actionbar is there? I couldn't find one but maybe I'm just blind. |
Well, the current deprecations are |
Wouldn’t that require a paper server? Just seems not worth it to require paper for titles subtitles and action bars (or am I wrong) |
You should ignore those deprecated methods. They are only deprecated to encourage adventure use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tests need to be done in the JUnit environment and with an actual player object.
You could look within EvtPlayerInputTest
to help guide you a bit.
Also, broadcast
ing is not a form of testing.
Mb, the broadcasts were just to help me personally with timing and stuff, I didn't intend for those to be part of the test. I figured just sending the titles/actionbars were what needed to be tested. |
You should look at this for the tests |
Description
This PR aims to add object support to sending titles, subtitles, and actionbars.
Also removed anything related to checking for support for timespans.
Target Minecraft Versions: any
Requirements: none
Related Issues: none