ItemType - fix error in loops #7418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
reviewed
Jan 9, 2025
Efnilite
added
the
bug
Efnilite
approved these changes
Jan 9, 2025
TheAbsolutionism
approved these changes
Jan 9, 2025
|
Poor lil fella, you've been missed on two updates now, 😔 |
|
This is used to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix a bug where looping over
all item typeswould throw an error.From what I gathered, the error is due to the container iterator where looping over the item datas was attempting to grab an ItemStack. If the ItemStack was not there (since it's a nullable getter), then it would throw an error.
This is due to the fact not all materials can be ItemStacks (ie: block only materials like WATER)
This PR is more created to be open for discussion. I stripped out the Container reference because it was returning ItemStacks??!?! Why exactly?!?!?
If I'm looping all ItemTypes I want ItemTypes not ItemStacks.
From what I can see the ONLY place the container stuff was referenced was in SecLoop and SecFor.
I don't believe this is needed, but I will leave it up to the team to decide.
Target Minecraft Versions: any
Requirements: none
Related Issues: #7414