Skip to content

Warden+ #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 31, 2025
Merged

Warden+ #7314

merged 16 commits into from
Mar 31, 2025

Conversation

Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Dec 27, 2024 •
edited
Loading

Description

This PR aims to add additional control over Wardens. Allowing users to set a wardens anger level towards an entity and make them sense a disturbance.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 27, 2024
ShaneBeee
ShaneBeee suggested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things

ShaneBeee
ShaneBeee suggested changes Dec 27, 2024
View reviewed changes
@Absolutionism @ShaneBeee
Update src/main/java/ch/njol/skript/effects/EffWardenDisturbance.java
f34e317 
Co-authored-by: Shane Bee <shanebolenback@me.com>
ShaneBeee
ShaneBeee approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my approval... for sport!

cheeezburga
cheeezburga previously requested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking real good.

sovdeeth
sovdeeth requested changes Dec 29, 2024
View reviewed changes
@Efnilite Efnilite added feature Pull request adding a new feature. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Dec 31, 2024
sovdeeth
sovdeeth requested changes Dec 31, 2024
View reviewed changes
@Absolutionism Absolutionism requested a review from a team as a code owner March 19, 2025 22:29
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 19, 2025
@sovdeeth sovdeeth removed the request for review from a team March 21, 2025 01:49
@erenkarakal erenkarakal merged commit bf0000f into SkriptLang:dev/feature Mar 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Efnilite Efnilite Efnilite approved these changes

@cheeezburga cheeezburga Awaiting requested review from cheeezburga

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud UnderscoreTud is a code owner automatically assigned from SkriptLang/core-developers

+1 more reviewer

@ShaneBeee ShaneBeee ShaneBeee approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Absolutionism @sovdeeth @ShaneBeee @Efnilite @cheeezburga @erenkarakal