Brewing Stand Support #7275
Merged
Brewing Stand Support #7275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vents # Conflicts: # src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java # src/main/java/ch/njol/skript/events/SimpleEvents.java
Efnilite
requested changes
Dec 18, 2024
src/main/java/ch/njol/skript/expressions/ExprBrewingFuelLevel.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondBrewingConsume.java
Outdated
Show resolved
Hide resolved
Efnilite
added
the
enhancement
Efnilite
requested changes
Dec 19, 2024
src/main/java/ch/njol/skript/conditions/CondBrewingConsume.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondBrewingConsume.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprBrewingFuelLevel.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprBrewingFuelLevel.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprBrewingFuelLevel.java
Outdated
Show resolved
Hide resolved
…vents # Conflicts: # src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Efnilite
approved these changes
Dec 19, 2024
…vents # Conflicts: # src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java # src/main/java/ch/njol/skript/events/SimpleEvents.java
Romitou
previously requested changes
Jan 12, 2025
sovdeeth
requested changes
Mar 20, 2025
src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondBrewingConsume.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondBrewingConsume.java
Outdated
Show resolved
Hide resolved
…vents # Conflicts: # src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java # src/main/java/ch/njol/skript/events/SimpleEvents.java
…vents # Conflicts: # src/main/java/ch/njol/skript/events/EvtItem.java
Efnilite
requested changes
Jul 5, 2025
src/main/java/ch/njol/skript/conditions/CondBrewingConsume.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprBrewingFuelLevel.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprBrewingFuelLevel.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprBrewingResults.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/brewing/elements/ExprBrewingSlot.java
Show resolved
Hide resolved
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Efnilite
approved these changes
Aug 1, 2025
APickledWalrus
approved these changes
Sep 30, 2025
Member
APickledWalrus
left a comment
APickledWalrus
left a comment
There was a problem hiding this comment.
I think it would be good to put this into a module and standardize some of the verb effects "make", "force", "prevent", "block", etc.
Not required for this to be merged though.
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.13 Releases
Absolutionism
requested review from
UnderscoreTud
and removed request for
a team
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.13 Releases
skriptlang-automation
bot
added
the
completed
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Initial Commit * Tests * Fix JUnit 17 * Requested Changes * Changes * Update EventValues * Requested Changes * Update Test * Requested Changes * Update EvtItem.java * Partial Changes * Update EvtItem.java * Brewing Results Changer * Update ExprBrewingTime.java * Changes * Pickle's Changes * Requested Changes * Apply suggestions from code review Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com> * Module * Update SimpleEvents.java
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Initial Commit * Tests * Fix JUnit 17 * Requested Changes * Changes * Update EventValues * Requested Changes * Update Test * Requested Changes * Update EvtItem.java * Partial Changes * Update EvtItem.java * Brewing Results Changer * Update ExprBrewingTime.java * Changes * Pickle's Changes * Requested Changes * Apply suggestions from code review Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com> * Module * Update SimpleEvents.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add additional brewing support such as events, expressions and slots. Allowing users to use a specific expression to get a specific slot of a brewing stand inventory, brewing stand events, and values such as brewing time and brewing fuel.
Target Minecraft Versions: any
Requirements: none
Related Issues: #5104