Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundReceiver - fix error on Spigot when adventure API is implemented #7271

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to fix an error when running Skript on Spigot when another plugin implements adventure API.
This issue was first brought to me by someone using Mohist, which I'm assuming implements adventure API but not fully.


Target Minecraft Versions: any
Requirements: none
Related Issues: #7261

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@APickledWalrus APickledWalrus added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Dec 17, 2024
@sovdeeth sovdeeth added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. 2.10 Targeting a 2.10.X version release labels Dec 17, 2024
@sovdeeth sovdeeth merged commit a44df2b into SkriptLang:dev/feature Dec 18, 2024
5 checks passed
@ShaneBeee ShaneBeee deleted the fix/sound-issue-on-spigot branch December 18, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.10 Targeting a 2.10.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants