Skip to content

Additional Dropped Item Elements #7270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Apr 1, 2025
Merged

Additional Dropped Item Elements #7270

merged 27 commits into from
Apr 1, 2025

Conversation

Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Dec 17, 2024 •
edited
Loading

Description

This PR aims to add additional elements relating to Dropped Items. Allowing users to get+set the owners and the entity that dropped items, as well as make them not despawn.

Target Minecraft Versions: any
Requirements: none
Related Issues: #5110

Fusezion
Fusezion suggested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc skript has a type registered for dropped entities can we make use of that instead of entity here so people don't interpret differently

APickledWalrus
APickledWalrus requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial thoughts

Fusezion
Fusezion suggested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the same as pickle probably

@Absolutionism
Copy link
Contributor Author

iirc skript has a type registered for dropped entities can we make use of that instead of entity here so people don't interpret differently

I'm not seeing any registered droppeditem or droppedentity

@Fusezion
Copy link
Contributor

iirc skript has a type registered for dropped entities can we make use of that instead of entity here so people don't interpret differently

I'm not seeing any registered droppeditem or droppedentity

it's likely itementity and would be registered with NoDocs
image

@Absolutionism
Copy link
Contributor Author

it's likely itementity and would be registered with NoDocs ![image](https://private-user-

ahhh ok, appreciate it

Fusezion
Fusezion suggested changes Dec 17, 2024
View reviewed changes
APickledWalrus
APickledWalrus requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better!

ShaneBeee
ShaneBeee suggested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few thoughts.

ShaneBeee
ShaneBeee reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some concerns I guess.

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 17, 2024
Efnilite
Efnilite requested changes Dec 17, 2024
View reviewed changes
ShaneBeee
ShaneBeee approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not a fan of returning null when something isn't null provided by Bukkit/Minecraft.
In my opinion this is super misleading.
ie: if owner/thrower of %itementity% is set: incorrectly returning false.
But if that is what the team wants, then I'll approve.

sovdeeth
sovdeeth requested changes Dec 19, 2024
View reviewed changes
APickledWalrus
APickledWalrus requested changes Dec 20, 2024
View reviewed changes
Efnilite
Efnilite approved these changes Dec 21, 2024
View reviewed changes
@Absolutionism Absolutionism requested a review from a team as a code owner March 19, 2025 22:29
@Absolutionism Absolutionism requested review from erenkarakal and removed request for Fusezion March 19, 2025 22:29
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 19, 2025
@sovdeeth sovdeeth removed the request for review from a team March 21, 2025 01:15
sovdeeth
sovdeeth requested changes Mar 21, 2025
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also may want to update this PR to use UUID instead of string, though that's optional.

@sovdeeth sovdeeth removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 21, 2025
@Absolutionism Absolutionism requested a review from sovdeeth March 22, 2025 14:01
sovdeeth
sovdeeth requested changes Mar 22, 2025
View reviewed changes
@Absolutionism Absolutionism requested a review from sovdeeth March 31, 2025 21:51
APickledWalrus
APickledWalrus requested changes Apr 1, 2025
View reviewed changes
@APickledWalrus APickledWalrus merged commit 3651df1 into SkriptLang:dev/feature Apr 1, 2025
5 checks passed
@Absolutionism Absolutionism mentioned this pull request Jun 14, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Burbulinis Burbulinis Burbulinis left review comments

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Efnilite Efnilite Efnilite approved these changes

@erenkarakal erenkarakal Awaiting requested review from erenkarakal erenkarakal is a code owner automatically assigned from SkriptLang/core-developers

+2 more reviewers

@Fusezion Fusezion Fusezion requested changes

@ShaneBeee ShaneBeee ShaneBeee approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Absolutionism @Fusezion @APickledWalrus @ShaneBeee @sovdeeth @Efnilite @Burbulinis