-
-
Notifications
You must be signed in to change notification settings - Fork 414
API for custom default values during parsing. #7256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for custom default values during parsing. #7256
Conversation
|
Just realized this needs to support multiple layers of default values. Will fix Friday. |
|
I would like some thoughts on how/whether to handle cases where context completely changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good. Just have a few comments I'd like discussion on before merging
* add custom default value api * handle nested custom defaults * requested changes * requested changes --------- Co-authored-by: Moderocky <admin@moderocky.com>
Description
Adds an api for declaring custom default values during parsing. Does not apply to runtime defaults like arithmetic.
The goal of this is to provide a slightly easier method for section to provide section-specific defaults without having to create an entire custom event and change the context.
I think this implementation might be a little rough and would welcome critiques.
Example:
Target Minecraft Versions: any
Requirements: none
Related Issues: none