Equippable components #7194

Absolutionism · 2024-11-04T23:19:40Z

Description

This PR aims to add support for the upcoming Equippable Components to Skript. Allowing users to modify the components of an item and create new equippable components with features such as: Dispensable, Damageable, Swappable, allowed entities, equip sound, and many more.

This will be marked as draft due to Equippable Components being ApiStatus.Experimental at this time.
Open to any syntax changes.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

src/main/resources/lang/default.lang

…leComponents # Conflicts: # src/main/java/ch/njol/skript/Skript.java # src/main/resources/lang/default.lang

Moderocky

Looks good.

sovdeeth · 2024-12-08T06:06:45Z

Can you explain the reasoning behind making the equippable component a new type? Why not just have all the syntaxes act on items, like you already have them doing?

Absolutionism · 2024-12-09T17:17:33Z

Can you explain the reasoning behind making the equippable component a new type? Why not just have all the syntaxes act on items, like you already have them doing?

I believe having this new type will be beneficial for storing template equippable components. I personally feel it to be more intuitive

…leComponents # Conflicts: # src/main/java/ch/njol/skript/util/slot/EquipmentSlot.java

…leComponents # Conflicts: # src/main/java/ch/njol/skript/Skript.java # src/main/java/ch/njol/skript/bukkitutil/SoundUtils.java # src/main/resources/lang/default.lang

…leComponents # Conflicts: # src/main/java/ch/njol/skript/Skript.java # src/main/java/ch/njol/skript/util/slot/EquipmentSlot.java # src/main/resources/lang/default.lang

APickledWalrus

Looking good. Perhaps I could persuade you to use Registration API for syntax? 🙂

src/main/java/ch/njol/skript/Skript.java

src/main/java/ch/njol/skript/util/ItemSource.java

src/main/java/org/skriptlang/skript/bukkit/itemcomponents/ComponentUtils.java

src/main/java/org/skriptlang/skript/bukkit/itemcomponents/ItemComponentModule.java

src/main/java/org/skriptlang/skript/bukkit/itemcomponents/equippable/EquippableWrapper.java

...va/org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/EffEquipCompInteract.java

...a/org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/EffEquipCompShearable.java

...a/org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/ExprEquipCompEntities.java

...java/org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/ExprEquipCompModel.java

…ppable/elements/ExprEquipCompModel.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

APickledWalrus

Almost ready

...rg/skriptlang/skript/bukkit/itemcomponents/equippable/elements/CondEquipCompDispensable.java

...a/org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/CondEquipCompInteract.java

.../org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/CondEquipCompShearable.java

.../skriptlang/skript/bukkit/itemcomponents/equippable/elements/CondEquipCompSwapEquipment.java

...org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/ExprEquipCompShearSound.java

...a/org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/ExprSecBlankEquipComp.java

.../org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/CondEquipCompShearable.java

…leComponents # Conflicts: # src/main/resources/lang/default.lang

* Starter Commit * PR ready * remove "runtime" * Changes * Update * Update * Overhaul * Update CondEquipCompInteract.java * Requested Changes * Partial Changes * Update EquippableComponents.sk * revert * Record Usage * Partial Changes * More Changes * Changes * Requested Changes * Update EquippableComponents.sk * Update EquippableComponents.sk * Adooblus Changes * Update EquippableExperiment.java * Update Experiment Class Name * Requested Changes * Cloneable Changes * Update EquippableModule.java * Update ItemComponentModule.java * Partial Update Experiencing some issues, need to see if incorrect merge * Docs Update * Missing Import * More Elements * Docs Fix * Fix ItemType * Revert Misc Changed Files * Source Retainability * Update EquippableComponents.sk * Update ExprEquippableComponent.java * Requested Changes * Update Wrapper * ComponentUtils * Docs Update * Update ExprSecBlankEquipComp.java * Merge dev/feature * Requested Changes * Update src/main/java/org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/ExprEquipCompModel.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com> * Pickles Changes - Part 20 * Update CondEquipCompShearable.java

Absolutionism added 2 commits November 4, 2024 01:39

Starter Commit

2cd6021

PR ready

feede48

Absolutionism marked this pull request as draft November 4, 2024 23:19

EquipableMC suggested changes Nov 4, 2024

View reviewed changes

src/main/resources/lang/default.lang Outdated Show resolved Hide resolved

remove "runtime"

1c22720

Efnilite added the feature Pull request adding a new feature. label Nov 5, 2024

Absolutionism and others added 3 commits November 8, 2024 01:16

Changes

6736a9d

Merge branch 'dev/feature' into dev/EquippableComponents

92e8162

Merge branch 'dev/feature' into dev/EquippableComponents

15d5fd7

Absolutionism marked this pull request as ready for review November 10, 2024 18:32

Absolutionism added 3 commits November 10, 2024 19:54

Update

01b3fe7

Merge branch 'dev/feature' into dev/EquippableComponents

70c7186

Merge remote-tracking branch 'upstream/dev/feature' into dev/Equippab…

d78a8f2

…leComponents # Conflicts: # src/main/java/ch/njol/skript/Skript.java # src/main/resources/lang/default.lang

Moderocky approved these changes Nov 30, 2024

View reviewed changes

Absolutionism added 5 commits December 14, 2024 21:34

Merge remote-tracking branch 'upstream/dev/feature' into dev/Equippab…

2500976

…leComponents # Conflicts: # src/main/java/ch/njol/skript/util/slot/EquipmentSlot.java

Merge branch 'dev/feature' into dev/EquippableComponents

8f944a2

Merge remote-tracking branch 'upstream/dev/feature' into dev/Equippab…

256781a

…leComponents # Conflicts: # src/main/java/ch/njol/skript/Skript.java # src/main/java/ch/njol/skript/bukkitutil/SoundUtils.java # src/main/resources/lang/default.lang

Update

e250c95

Merge branch 'dev/feature' into dev/EquippableComponents

7e59693

Burbulinis mentioned this pull request Jan 19, 2025

Spawners Incoming #7477

Closed

Merge remote-tracking branch 'upstream/dev/feature' into dev/Equippab…

cc57b63

…leComponents # Conflicts: # src/main/java/ch/njol/skript/Skript.java # src/main/java/ch/njol/skript/util/slot/EquipmentSlot.java # src/main/resources/lang/default.lang

Absolutionism requested review from a team as code owners May 11, 2025 07:01

Absolutionism requested review from UnderscoreTud and sovdeeth and removed request for a team May 11, 2025 07:01

Absolutionism added 2 commits May 11, 2025 03:02

Overhaul

2c2cc84

Update CondEquipCompInteract.java

e889044

Requested Changes

29d6648

sovdeeth approved these changes Aug 29, 2025

View reviewed changes

sovdeeth and others added 5 commits August 29, 2025 10:49

Merge branch 'dev/feature' into dev/EquippableComponents

21f02d9

Update Wrapper

3e79e27

ComponentUtils

eb322ab

Docs Update

3a48edb

Update ExprSecBlankEquipComp.java

30634be

Absolutionism requested a review from Efnilite as a code owner September 10, 2025 01:10

Absolutionism and others added 2 commits September 9, 2025 21:13

Merge dev/feature

edc11dc

Merge branch 'dev/feature' into dev/EquippableComponents

53dedc7

APickledWalrus requested changes Sep 10, 2025

View reviewed changes

Absolutionism requested a review from APickledWalrus September 10, 2025 05:08

Requested Changes

8402a68

Absolutionism requested a review from sovdeeth September 16, 2025 03:37

sovdeeth approved these changes Sep 16, 2025

View reviewed changes

...java/org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/ExprEquipCompModel.java Outdated Show resolved Hide resolved

Absolutionism and others added 3 commits September 16, 2025 18:18

Update src/main/java/org/skriptlang/skript/bukkit/itemcomponents/equi…

6f43d87

…ppable/elements/ExprEquipCompModel.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>

Merge branch 'dev/feature' into dev/EquippableComponents

211c72e

Merge branch 'dev/feature' into dev/EquippableComponents

6252037

APickledWalrus requested changes Sep 30, 2025

View reviewed changes

Absolutionism requested a review from APickledWalrus September 30, 2025 22:13

Pickles Changes - Part 20

4d44e72

APickledWalrus approved these changes Sep 30, 2025

View reviewed changes

.../org/skriptlang/skript/bukkit/itemcomponents/equippable/elements/CondEquipCompShearable.java Outdated Show resolved Hide resolved

github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Sep 30, 2025

Absolutionism added 2 commits September 30, 2025 18:36

Update CondEquipCompShearable.java

af4356f

Merge remote-tracking branch 'upstream/dev/feature' into dev/Equippab…

b81f0ef

…leComponents # Conflicts: # src/main/resources/lang/default.lang

Absolutionism merged commit 8f657a8 into SkriptLang:dev/feature Sep 30, 2025
5 checks passed

github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Sep 30, 2025

sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Oct 15, 2025

Uh oh!

Equippable components #7194

Equippable components #7194

Uh oh!

Conversation

Absolutionism commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Uh oh!

Moderocky left a comment

Choose a reason for hiding this comment

Uh oh!

sovdeeth commented Dec 8, 2024

Uh oh!

Absolutionism commented Dec 9, 2024

Uh oh!

APickledWalrus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

APickledWalrus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Absolutionism commented Nov 4, 2024 •

edited

Loading