Skip to content

Add number format function #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Oct 31, 2024
Merged

Add number format function #7166

merged 29 commits into from
Oct 31, 2024

Conversation

Efnilite
Copy link
Member

Description

Continues #4663.

  • Format now depends on whether passed value is a decimal or whole number. Previously, this would round decimal numbers down to integers, which may be unexpected behaviour for people who want to format decimal numbers as decimals.
    • formatNumber(123456) -> 123,456
    • formatNumber(123456.7890) -> 123,456.79
  • Improved tests with none, NaN, infinity, floats

Thanks @AyhamAl-Ali!

Target Minecraft Versions: any
Requirements: none
Related Issues: none

AyhamAl-Ali and others added 28 commits March 15, 2022 15:56
@AyhamAl-Ali
🚀 Add number format expression
f1a8f7f
@AyhamAl-Ali
Little changes
c7b37d8
@AyhamAl-Ali
Prevent variables usage
cde535c
@AyhamAl-Ali
Support variables as custom format
ee12498
@AyhamAl-Ali
Make it return null if format is invalid
f2348ed
@AyhamAl-Ali
Add test script
df572d8
@AyhamAl-Ali
Update test script
05307fd
@AyhamAl-Ali
Update test script
66f12a4
@AyhamAl-Ali
Changes
7184c95
@AyhamAl-Ali
Fix class to use same technique as #4664
dc61b39
@AyhamAl-Ali
Merge branch 'master' into ench/formatted-number
cc78229
@AyhamAl-Ali @TheLimeGlass
Apply suggestions from code review
8654a94 
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
@AyhamAl-Ali
Add helpful comments and use lambda
f30aded
@AyhamAl-Ali @TheLimeGlass
Update src/main/java/ch/njol/skript/expressions/ExprFormatNumber.java
b4077e8 
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
@AyhamAl-Ali
Change expression to function
25d66c1
@AyhamAl-Ali
Remove unused imports
ecd4a4a
@AyhamAl-Ali
Merge branch 'dev/feature' into ench/formatted-number
0d5dc9a
@AyhamAl-Ali
Refactoring and merge base, updating examples
4488904
@AyhamAl-Ali
return null instead of empty string
664ebf1
@AyhamAl-Ali
Update examples
0ce55ab
@AyhamAl-Ali
Warn instead of erroring, but probably better to remove
a04f476
@AyhamAl-Ali
Address reviews
f238bc0
@AyhamAl-Ali
better variable naming
80be1e0
@Moderocky
Merge branch 'dev/feature' into ench/formatted-number
ac9a7b4
@Moderocky
Merge branch 'dev/feature' into ench/formatted-number
9cdec48
@Moderocky
Merge branch 'dev/feature' into ench/formatted-number
926ee62
@Efnilite
Merge branch 'fork/AyhamAl-Ali/ench/formatted-number' into formatted-…
78fa7c4 
…number

# Conflicts:
#	src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java
@Efnilite
init commit
8bfe6c9
@Efnilite Efnilite added the feature Pull request adding a new feature. label Oct 28, 2024
@Efnilite Efnilite mentioned this pull request Oct 28, 2024
Closed
@Efnilite Efnilite requested a review from sovdeeth October 28, 2024 21:40
@Moderocky Moderocky added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Oct 29, 2024
@sovdeeth sovdeeth merged commit 9786eb4 into SkriptLang:dev/feature Oct 31, 2024
5 checks passed
@Efnilite Efnilite deleted the formatted-number branch October 31, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

@cheeezburga cheeezburga cheeezburga approved these changes

Assignees
No one assigned
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Efnilite @sovdeeth @Moderocky @cheeezburga @AyhamAl-Ali