Skip to content

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Sep 22, 2024

Description

Continuation of #5584. Reverts the breaking change in ExprExperience in the previous PR.

  • Added EntityBreedEvent
  • Added EntityEnterLoveModeEvent
  • Added ExprBreedingFamily
  • Added CondCanAge
  • Added CondCanBreed
  • Added EffAllowAging
  • Added EffBreedable
  • Added ExprLoveTime
  • Added CondIsAdult, CondIsChild
  • Added EffMakeAdult
  • Updated ExprExperience
  • Added tests for everything

Thanks @Fusezion!


Target Minecraft Versions: any
Requirements: none
Related Issues: #5111

Fusezion and others added 30 commits March 29, 2023 20:33
📎 Added EntityEnterLoveModeEvent
🐷 Added EntityBreedEvent
✨ Added EventValues for these events
👪 Added family expression for Father, Mother, Child, and Breeder
✨ Added breeding experience to experience class
*update class to current standards
✨ Added condition for checking ageable
✨ Added condition for checking breedable
✨ Added effect for toggle breedable
✨ Added effect for locking age
✨ Added expression for love ticks
🐛 Fixed issue with `livingentities`
🐛 Added class exist checks for Breedable instances
✨ Added RequirePlugins annotation to select classes
📋 Added test for ExprLoveTime & CondIsInLove
📋 Addes test for EffBreedable & CondCanBreed
📋 Added test fpr EffLockAge & CondCanAge
✨ Added Condition for checking is adult
✨ Added Effect to make an entity a baby or adult
📋 Added test for these syntaxes
🔵 1.16 for any mob, below that is animals only
Thanks for all these formatting changes it's just what I wanted when waking up

Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
✨ Renamed expression to ExprLoveTicks
✨ Added support for ticks via integers
📋 Added a new test for using integers
📋 Removed unneeded test condition
✨ Changed expression for father, mother and offspring a bit
✨ Converted get to a switch statement
🐛 Fixed an issue where set allowed more than one value
🐛 Fixed a typo in examples
✨ Added a spacer to examples
Co-Authored-By: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
Just adds some notes in descriptions to bring more light to animal exclusive syntax

Co-Authored-By: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
🐛 fix accidental forgotten example
🔴 remove integer support from love ticks expression
📋 remove a test from CondIsInLove.sk

Co-Authored-By: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
🐛 Fixed an issue with ExprLoveTicks not working correctly
📋 Updated test to include more checks for add, remove and reset
Co-Authored-By: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>
@Efnilite Efnilite requested a review from Asleeepp September 24, 2024 10:13
@Examples({
"on right click on living entity:",
"\tevent-entity can't breed",
"\tsend \"Turns out %event-entity% is not breedable. Must be a Skript user!\" to player"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀

@Efnilite Efnilite requested a review from sovdeeth September 26, 2024 23:08
@Efnilite Efnilite requested review from Moderocky and removed request for Asleeepp October 26, 2024 14:32
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Oct 26, 2024
@sovdeeth sovdeeth merged commit ead4ca4 into SkriptLang:dev/feature Oct 31, 2024
5 checks passed
@Efnilite Efnilite deleted the breeding branch October 31, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants