Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Generate Missing Aliases #7073

Merged

Conversation

erenkarakal
Copy link
Member

@erenkarakal erenkarakal commented Sep 13, 2024

Description

This PR lets Skript use temporary aliases for enum classes when Minecraft adds new entity types or other stuff that Skript doesn't know about yet. Example: [Skript] Missing lang enum constant for 'teleport causes.END_GATEWAY'. Using teleport causes:end gateway for now. means you can use teleport causes:end gateway until Skript adds it to the language file.

It uses : instead of . to prevent conflict with skript-reflect and I think it fits Skript more.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Moderocky
Copy link
Member

Moderocky commented Sep 13, 2024

I wonder whether we could get something a bit more english-like than <type name>:<enum name>, maybe <enum name> <singular type name>? (Should create things like end gateway teleport cause, unknown transform reason, raining weather type etc.)

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Sep 13, 2024
@sovdeeth sovdeeth changed the base branch from dev/feature to dev/patch September 13, 2024 15:17
@sovdeeth sovdeeth changed the base branch from dev/patch to dev/feature September 13, 2024 15:19
@sovdeeth
Copy link
Member

ok well i think this should be patch but i don't want to deal with the rebasing

@erenkarakal erenkarakal removed the request for review from Moderocky September 13, 2024 15:55
@erenkarakal erenkarakal changed the title Auto Generated Aliases Auto Generate Missing Aliases Sep 13, 2024
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Sep 14, 2024
@sovdeeth sovdeeth merged commit 0d19871 into SkriptLang:dev/feature Oct 13, 2024
5 checks passed
@Efnilite Efnilite mentioned this pull request Dec 25, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants