Skip to content

Conversation

Asleeepp
Copy link
Contributor

Description

Adds a config option to allow all players with the permission, to see whenever a player reloads a script, and the info that comes along with it, such as errors and/or warnings, etc.


Target Minecraft Versions: any
Requirements: none
Related Issues: #6736

Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preliminary look-through

@Asleeepp Asleeepp requested a review from sovdeeth June 11, 2024 18:03
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good but I would like to see an example of what it looks like.

@sovdeeth sovdeeth added the feature Pull request adding a new feature. label Jun 28, 2024
@Asleeepp Asleeepp requested a review from sovdeeth June 28, 2024 17:15
@sovdeeth sovdeeth added the 2.9 label Jun 29, 2024
@Moderocky Moderocky force-pushed the addition-operators-reloading-info branch from aa33f20 to 96edf65 Compare July 1, 2024 08:13
Asleeepp added 2 commits July 1, 2024 12:46
…o' into addition-operators-reloading-info

# Conflicts:
#	src/main/resources/plugin.yml
@Asleeepp Asleeepp requested a review from Moderocky July 1, 2024 15:48
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking in general it might be better to instead support multiple command senders in RedirectingLogHandler. It would avoid some of the more awkward changes.

@APickledWalrus APickledWalrus removed the 2.9 label Jul 1, 2024
@sovdeeth sovdeeth requested a review from APickledWalrus July 1, 2024 22:44
@Asleeepp Asleeepp requested a review from APickledWalrus July 12, 2024 18:07
@APickledWalrus APickledWalrus requested a review from sovdeeth July 14, 2024 04:03
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some slight changes

@Asleeepp Asleeepp requested a review from sovdeeth July 14, 2024 20:26
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jul 18, 2024
@Asleeepp Asleeepp requested a review from sovdeeth August 15, 2024 01:16
@sovdeeth sovdeeth added the 2.10 label Aug 16, 2024
@Moderocky Moderocky merged commit c8cd975 into SkriptLang:dev/feature Aug 30, 2024
3 checks passed
@Moderocky Moderocky deleted the addition-operators-reloading-info branch August 30, 2024 13:54
@EquipableMC
Copy link
Contributor

EquipableMC commented Sep 21, 2024

Issue with this, redirectingloghandler breaks stuff, I don't know why this was merged.

image

EquipableMC added a commit to EquipableMC/Skript that referenced this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants