Skip to content

Add Player Chat Completion Suggestions #6419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 22, 2024
Merged

Add Player Chat Completion Suggestions #6419

merged 13 commits into from
Sep 22, 2024

Conversation

NotSoDelayed
Copy link
Contributor

@AyhamAl-Ali AyhamAl-Ali added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). feature Pull request adding a new feature. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Feb 11, 2024
AyhamAl-Ali
AyhamAl-Ali previously requested changes Feb 11, 2024
View reviewed changes
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ⚡

@AyhamAl-Ali
Copy link
Member

@DelayedGaming 👋

sovdeeth
sovdeeth requested changes Apr 13, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@NotSoDelayed NotSoDelayed requested a review from sovdeeth April 15, 2024 11:51
sovdeeth
sovdeeth approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than a small description change.

Moderocky
Moderocky approved these changes Apr 15, 2024
View reviewed changes
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jul 20, 2024
@NotSoDelayed
Copy link
Contributor Author

Java 17 ready!

@sovdeeth sovdeeth merged commit 83808a1 into SkriptLang:dev/feature Sep 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

@AyhamAl-Ali AyhamAl-Ali Awaiting requested review from AyhamAl-Ali

Assignees
No one assigned
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NotSoDelayed @AyhamAl-Ali @sovdeeth @Moderocky