ExprPlayerViewDistance - re-enable this expression

[ShaneBeee]

Description

This PR aims to re-enable the view distance expression.
This was previously removed as it was "not supported" in Paper starting in 1.14.
I'm not entirely sure which version it was re-enabled, but I do know this has been working since at least 1.17
My guess would be 1.14-1.16.x this is not working. Generally no one uses 1.14/1.15, and very very few use 1.16.x, so we shouldn't need to worry.

If the server version doesn't have this enabled:

• get -> will return the server's view distance
• change -> an error will be sent to console letting the user know this is NOT a Skript bug

---

Target Minecraft Versions: none
Requirements: none
Related Issues: none

[Pikachu920]

instead of writing the error to console on failure, is it possible to error on acceptsChange if it's unsupported?

[ShaneBeee]

instead of writing the error to console on failure, is it possible to error on acceptsChange if it's unsupported?

unfortunately there is nothing in the API regarding if it does/doesn't work, therefor no way to check until its actually executed

[kiip1]

On 1.19.3 the method is Player#getClientViewDistance()

[ShaneBeee]

On 1.19.3 the method is Player#getClientViewDistance()

that is to get the view distance set on the client, not the view distance the server has set for the client,
as per docs:

Get the player's current client side view distance.
Will default to the server view distance if the client has not yet communicated this information,

[kiip1]

On 1.19.3 the method is Player#getClientViewDistance()

that is to get the view distance set on the client, not the view distance the server has set for the client,

as per docs:

Get the player's current client side view distance.

Will default to the server view distance if the client has not yet communicated this information,

I see, should be ok then.

[AyhamAl-Ali]

Note: It's better to mention the note (about the 1.14 issue and it would return bukkit view distance in a specific case) in the docs description

[ShaneBeee]

Note: It's better to mention the note (about the 1.14 issue and it would return bukkit view distance in a specific case) in the docs description

Good call, a note has been added to the docs.

[TheLimeGlass]

Why can't we use Spigot's Player#getClientViewDistance? This will allow getting on Spigot servers.

[ShaneBeee]

Why can't we use Spigot's Player#getClientViewDistance? This will allow getting on Spigot servers.

This is completely unrelated.
Player#getClientViewDistance() will return the view distance set on the client. Completely not related to the server at all.

[TheLimeGlass]

Why can't we use Spigot's Player#getClientViewDistance? This will allow getting on Spigot servers.

This is completely unrelated. Player#getClientViewDistance() will return the view distance set on the client. Completely not related to the server at all.

Can that be disclosed in the syntax description? Even kiip1 called the same question.

[ShaneBeee]

Why can't we use Spigot's Player#getClientViewDistance? This will allow getting on Spigot servers.

This is completely unrelated. Player#getClientViewDistance() will return the view distance set on the client. Completely not related to the server at all.

Can that be disclosed in the syntax description? Even kiip1 called the same question.

ok description has been updated.
Also I re-added in the method check, as I removed that by accident.