Fix toString of TypePatternElement #5136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
the
enhancement
AyhamAl-Ali
approved these changes
Oct 4, 2022
APickledWalrus
approved these changes
Oct 6, 2022
TheLimeGlass
pushed a commit
that referenced
this pull request
Oct 20, 2022
(cherry picked from commit eea0e1a)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the toString of TypePatternElement, was a small mistake:
If the type doesn't take expressions (
(flagMask & SkriptParser.PARSE_EXPRESSIONS) == 0), it means we need to add a*, not a~. The code had it switched. For types without flags, it'd have added both, if not for the check right before checking if it's not the default flags.Btw, this change will likely not impact anything at all, because it's just the toString of a pattern, which isn't used in Skript and I doubt it's used in addons
Target Minecraft Versions:
Requirements:
Related Issues: