-
-
Notifications
You must be signed in to change notification settings - Fork 403
Add lang file updates on version change #5072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lang file updates on version change #5072
Conversation
Noice PR ⚡ 1- I don't know if any addon is using such system yet so IMO we can decide this later when we get more feedback on it. However, I would like this to have an option (in config.sk) so that users can choose to toggle auto update lang files in case they want to manually update with their custom lang files |
That could be useful, however outdated lang files may result in console errors (as reported for Structure API, see https://discord.com/channels/988998880794402856/1012003185302450206/1013589722586689588 - testing guild). This is why I opted for backups, as it ensures lang files will be up to date (but also preserves a user's work if they care to update it) |
The choice relies on whether it's preferred to 1- Override the user lang files with the new lang files and force the users to adapt their custom lang files every update manually Based on the answer the default value of |
Can this pull request also target the materials.json? Issue(s) stated here with error #4861 |
With the latest commit, it will only create backups if the lang file has been changed. If allowing a bypass really is desirable, potentially we can find a way to provide a more meaningful error message :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Maybe when we move on from Java 1.8 we can use try-with-resources.
Addresses TP's concerns
Description
This PR enables lang file updates when Skript detects a version change.
There are a few questions where I'm looking for input though:
Target Minecraft Versions: Any
Requirements: N/A
Related Issues: Needs merged before: