Fix conversion for list-modifying expressions #5052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
the
enhancement
1 task
TheLimeGlass
approved these changes
Oct 17, 2022
APickledWalrus
approved these changes
Oct 20, 2022
TheLimeGlass
pushed a commit
that referenced
this pull request
Oct 20, 2022
Add getConvertedExpression for list-modifying expressions (cherry picked from commit c52f055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement getConvertedExpression properly for reversed, shuffled and sorted list expression.
Example of what this changes will fix:
set {_l::*} to length of (reversed (1 and 2))shouldn't parse (length expr gets the length of a string), without this PR it parses just fine, since the conversion happens on the list-modifying expression instead of the list within.
Target Minecraft Versions:
Requirements:
Related Issues: #5045 (comment) (non-fixing)