-
-
Notifications
You must be signed in to change notification settings - Fork 407
Add french translation #5035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add french translation #5035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing missing Capital letter and adding symbols not present in english.lang.
This seems to be a really good french translation, good work ! |
63e11e4
to
a986db9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the missing change, for me there is nothing else to change. Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
En tant que français je valide également cette traduction :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. We can get a second org review on this then merge I think.
Description
This Pull Request adds the default language file
french.lang
.Considering the difficulty I had translating some key words into French to keep an equivalent meaning, I would especially like to receive some reviews from the French community and know what you think about it! Also, I thought it was appropriate to use the formal pronoun vous to address users. Let me know what you think too! :)
If you have any questions about a translation or suggestions for improvement, please don't hesitate!
Target Minecraft Versions: any
Requirements: none
Related Issues: none