Skip to content

Conversation

Romitou
Copy link
Member

@Romitou Romitou commented Aug 16, 2022

Description

This Pull Request adds the default language file french.lang.

Considering the difficulty I had translating some key words into French to keep an equivalent meaning, I would especially like to receive some reviews from the French community and know what you think about it! Also, I thought it was appropriate to use the formal pronoun vous to address users. Let me know what you think too! :)

If you have any questions about a translation or suggestions for improvement, please don't hesitate!


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@AyhamAl-Ali AyhamAl-Ali added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Aug 16, 2022
@TheLimeGlass TheLimeGlass requested a review from Olyno August 16, 2022 08:45
@TheLimeGlass TheLimeGlass requested a review from Xamez August 16, 2022 14:21
Copy link

@Anarchick Anarchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing missing Capital letter and adding symbols not present in english.lang.

@Weefle
Copy link
Contributor

Weefle commented Aug 17, 2022

This seems to be a really good french translation, good work !

Copy link

@Xamez Xamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the missing change, for me there is nothing else to change. Good job!

@TheLimeGlass TheLimeGlass requested a review from Anarchick August 19, 2022 15:31
Copy link
Contributor

@Olyno Olyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Soufreur78
Copy link

En tant que français je valide également cette traduction :)

Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. We can get a second org review on this then merge I think.

@TheLimeGlass TheLimeGlass merged commit 9764611 into SkriptLang:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants