Fix Actions not running on master branch #5011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
bug
AyhamAl-Ali
approved these changes
Aug 5, 2022
|
We are a pull request only push system right now, so there isn't really a need to waste our 2000 monthly minutes on running the same test twice. I think it's better to have them disabled on the master branch. The pull request check is enough. |
|
The 2000 minutes a month is only for private repos, it doesn't count for this repo Besides, the master branch adds that all users can download a nightly build from the latest commit instead of having to build themselves |
APickledWalrus
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the tests not running on the master branch, when a commit is made. This is caused by #4946, which mistakenly used the branch name
maininstead ofmaster, but we don't have such a branch.Target Minecraft Versions: any
Requirements: none
Related Issues: #4946 (non-fixing)