Improve event values move events

[TPGamesNL]

Description

Change PlayerTeleportEvent location event value to include PlayerMoveEvent (first extends the latter)
Add PlayerMoveEvent default and future location event value
Add EntityMoveEvent location event values
Also added more specific event classes to EvtMove

---

Target Minecraft Versions: partially Paper 1.16+
Requirements: none
Related Issues: #4890

[AyhamAl-Ali]

LGTM. Just a question, why is PlayerMoveEvent getFrom() at time -1 and getTo() at time 0 while EntityMoveEvent getFrom() at time 0 and getTo() at time 1?

[TPGamesNL]

The difference between these things determines which will be the default. If they're -1 and 0, the default is the future state, and if they're 0 and 1, the default is the past state.

For PlayerMoveEvent, I chose the default to be the future state, because if you cancel a move event, the client sees it as being teleported back after moving instead of actually not moving. This means, to the client, the player has moved already so their location is updated already. If you think it's more practically useful the other way around, lmk (for example, I don't know how the server handles it internally, what the actual player's location is, or how other clients see the player).

For EntityMoveEvent, I chose the default to be the past state, again due to the cancellation stuff. When I tried pushing the entity, they just didn't move at all, therefore I think it makes more sense to have the previous location as default.

[AyhamAl-Ali]

Cool! your choice fits the situation IMO.