Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for registering custom VariableStorage #4873

Merged
merged 20 commits into from
Apr 25, 2023
Merged

Add support for registering custom VariableStorage #4873

merged 20 commits into from
Apr 25, 2023

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Jul 7, 2022 •
edited
Loading

Description

Add support for registering custom VariableStorage, so addons can register a custom storage.

Related issues: #1787

@AyhamAl-Ali AyhamAl-Ali added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jul 7, 2022
@TPGamesNL TPGamesNL added the variables Related to variables and/or storing them. label Jul 7, 2022
@TheLimeGlass TheLimeGlass added the needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. label Jul 7, 2022
@TheLimeGlass
Copy link
Contributor Author

TheLimeGlass commented Jul 7, 2022 •
edited
Loading

This will need extensive testing, mainly because variables load after all syntaxes and addons in order to allow for addons to register a variable storage while also being dependent on Skript. I don't think it'll impact anything, but again testing.

@TheLimeGlass TheLimeGlass requested a review from TPGamesNL July 8, 2022 05:22
APickledWalrus
APickledWalrus requested changes Jul 15, 2022
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one thing as my IDE was giving me warnings across the files due to this

Moderocky
Moderocky approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sound.

TPGamesNL
TPGamesNL previously requested changes Nov 10, 2022
View reviewed changes
TheLimeGlass and others added 4 commits November 10, 2022 16:39
@TheLimeGlass @TPGamesNL
Update src/main/java/ch/njol/skript/Skript.java
1b6cfb6 
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
@TheLimeGlass @TPGamesNL
Update src/main/java/ch/njol/skript/Skript.java
5cc076b 
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
@TheLimeGlass @TPGamesNL
Update src/main/java/ch/njol/skript/Skript.java
25c287f 
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
@TheLimeGlass @TPGamesNL
Update src/main/java/ch/njol/skript/variables/SQLiteStorage.java
15f69f5 
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
@TheLimeGlass TheLimeGlass removed the needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. label Nov 24, 2022
@TheLimeGlass TheLimeGlass mentioned this pull request Dec 2, 2022
Open
kiip1
kiip1 reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@kiip1 kiip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a must! Small things.

@TheLimeGlass TheLimeGlass requested a review from TPGamesNL January 5, 2023 02:20
@TPGamesNL TPGamesNL mentioned this pull request Jan 29, 2023
Merged
@TPGamesNL TPGamesNL removed their request for review April 21, 2023 12:50
@TheLimeGlass TheLimeGlass added feature Pull request adding a new feature. and removed 2.8 labels Apr 21, 2023
AyhamAl-Ali
AyhamAl-Ali reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ⚡ Well done

@TheLimeGlass TheLimeGlass merged commit 655eb7f into SkriptLang:master Apr 25, 2023
@TheLimeGlass TheLimeGlass deleted the variable-api branch April 25, 2023 15:00
@TheLimeGlass TheLimeGlass mentioned this pull request Apr 26, 2023
Merged
@ShaneBeee ShaneBeee mentioned this pull request Aug 5, 2023
Closed
1 task
@APickledWalrus APickledWalrus mentioned this pull request Aug 8, 2023
Merged
kiip1 pushed a commit to mlummh/mlum-skript that referenced this pull request Oct 9, 2023
@TheLimeGlass @kiip1
Add support for registering custom VariableStorage (SkriptLang#4873)
8ef1f6f 
(cherry picked from commit 655eb7f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moderocky Moderocky Moderocky approved these changes

@AyhamAl-Ali AyhamAl-Ali AyhamAl-Ali approved these changes

@kiip1 kiip1 kiip1 approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@TPGamesNL TPGamesNL TPGamesNL left review comments

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature Pull request adding a new feature. variables Related to variables and/or storing them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TheLimeGlass @Moderocky @AyhamAl-Ali @kiip1 @APickledWalrus @TPGamesNL