-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix variable names with long numbers #4737
Fix variable names with long numbers #4737
Conversation
… and is therefore not restricted to ~19 digits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as this has been tested, it should be fine. A test should be added though if possible.
I also have to ask, why are variable names compared to this extent? Is there a reason to know more than whether or not the names are the same?
If we want to loop a list variable with number indices, we want to make sure it loops from 1-n, not an arbitrary order. Same for non-number indices, we want them to loop in alphabetical order, but also if we have sth like
|
Add test for numerical indices order
(cherry picked from commit 145bc59)
Description
Changes the variable name comparator to not rely on long parsing, instead comparing digits manually.
Output from the test script in the first linked issue:

Other test code:
Output: https://pastebin.com/htAPMQXg
Target Minecraft Versions: any
Requirements: none
Related Issues: #4729, #3929 (latter non-fixing)