Add world null check #4700
Merged
Add world null check #4700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
the
bug
|
Do you think we should instead fallback to the entity's world if the location's world is null? |
|
@TPGamesNL I can handle this change if you would like 🙂 |
|
Oh yea I forgot about this PR, feel free to do it otherwise I will tmrw |
TheLimeGlass
approved these changes
Jul 22, 2022
APickledWalrus
approved these changes
Jul 23, 2022
|
@TPGamesNL did this have a related issue or did you or someone on Discord find the NPE? |
|
I don't remember, but probably no related issues otherwise I would've referred them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes EffTeleport throwing NPE when a world's location is null:
NPEs: https://pastebin.com/u48v5Fjt (Paper async), https://pastebin.com/gj8rqxsW (sync)
Target Minecraft Versions: any
Requirements: none
Related Issues: none