🚀 Add anvil repair cost expression #4617

AyhamAl-Ali · 2022-02-21T19:27:39Z

Description

This PR add a new expression for anvil repair [max] cost
Note: This would work perfectly with AnvilPrepareEvent but due to the event's bugs I used the inventory click event which works as well

Target Minecraft Versions: MC 1.11+
Requirements: MC 1.11, MC 1.13+ (max cost)
Related Issues: None

- This would work perfectly with AnvilPrepareEvent but due to the event's bugs I used the inventory click event which works as well

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>

…to feature/anvil-cost-expr

Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

TheLimeGlass · 2022-10-26T06:31:32Z

I think inventory and anvilInventory or anvil are better naming too.

AyhamAl-Ali · 2022-10-26T20:19:21Z

I think inventory and anvilInventory or anvil are better naming too.

Can you point to what you're talking about?

TheLimeGlass · 2022-10-26T20:38:23Z

I think inventory and anvilInventory or anvil are better naming too.

Can you point to what you're talking about?

inv and aInv

…to feature/anvil-cost-expr

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

Co-authored-by: Fusezion <fusezionstream@gmail.com>

TheLimeGlass · 2023-05-04T21:07:51Z

@AyhamAl-Ali why was the test cancelled?

🚀 Add anvil repair cost expression

67a14de

- This would work perfectly with AnvilPrepareEvent but due to the event's bugs I used the inventory click event which works as well

AyhamAl-Ali added the feature Pull request adding a new feature. label Feb 21, 2022

APickledWalrus requested changes Mar 5, 2022

View reviewed changes

Changes

e4e1b84

AyhamAl-Ali requested a review from APickledWalrus March 5, 2022 12:38

Styling

aaf9b95

APickledWalrus added the 2.7 label Jul 15, 2022

APickledWalrus requested changes Jul 15, 2022

View reviewed changes

AyhamAl-Ali mentioned this pull request Jul 15, 2022

🚀 Add Anvil Damage Event #4619

Merged

AyhamAl-Ali and others added 4 commits July 15, 2022 14:13

Apply suggestions from code review

61f70a5

Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>

Merge branch 'master' into feature/anvil-cost-expr

40dcafc

Improvements

dece292

Merge branch 'master' into feature/anvil-cost-expr

4414a21

AyhamAl-Ali requested a review from APickledWalrus July 17, 2022 16:43

APickledWalrus approved these changes Jul 18, 2022

View reviewed changes

AyhamAl-Ali requested a review from TPGamesNL July 18, 2022 09:29

TPGamesNL requested changes Jul 19, 2022

View reviewed changes

AyhamAl-Ali and others added 3 commits July 19, 2022 15:23

Update src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

5f0a5e8

Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>

Add RESET for max & Improve examples

e1abcea

Merge remote-tracking branch 'AyhamAl-Ali/feature/anvil-cost-expr' in…

2df0267

…to feature/anvil-cost-expr

AyhamAl-Ali requested a review from TPGamesNL August 5, 2022 23:08

Update src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

88ced8a

Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>

TPGamesNL reviewed Aug 30, 2022

View reviewed changes

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java Outdated Show resolved Hide resolved

Update src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

e35ae69

Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>

AyhamAl-Ali requested a review from TPGamesNL August 30, 2022 15:24

TPGamesNL approved these changes Aug 30, 2022

View reviewed changes

TheLimeGlass suggested changes Oct 26, 2022

View reviewed changes

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java Outdated Show resolved Hide resolved

AyhamAl-Ali added 6 commits January 1, 2023 22:49

Better naming & event

c0b732d

Merge remote-tracking branch 'AyhamAl-Ali/feature/anvil-cost-expr' in…

826b373

…to feature/anvil-cost-expr

Fix some reverted changes

7bb118d

Merge branch 'master' into feature/anvil-cost-expr

18b0d98

inv Naming

5af97f0

Merge remote-tracking branch 'AyhamAl-Ali/feature/anvil-cost-expr' in…

83b0c6f

…to feature/anvil-cost-expr

AyhamAl-Ali requested a review from TheLimeGlass January 1, 2023 20:05

TheLimeGlass suggested changes Jan 2, 2023

View reviewed changes

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java Outdated Show resolved Hide resolved

TheLimeGlass removed the 2.7 label Jan 11, 2023

AyhamAl-Ali added 2 commits February 5, 2023 21:21

return super.init

7a1767c

Merge branch 'master' into feature/anvil-cost-expr

6d0f096

AyhamAl-Ali requested a review from TheLimeGlass February 5, 2023 18:22

TheLimeGlass suggested changes Feb 18, 2023

View reviewed changes

AyhamAl-Ali and others added 5 commits April 22, 2023 03:05

Update src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

5b25a56

Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>

Update src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

32a6126

Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>

Update src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

b535f34

Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>

Update src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

2230f42

Co-authored-by: LimeGlass <16087552+TheLimeGlass@users.noreply.github.com>

Requested Changes

1cade76

AyhamAl-Ali requested a review from TheLimeGlass April 22, 2023 00:07

TheLimeGlass approved these changes Apr 22, 2023

View reviewed changes

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java Outdated Show resolved Hide resolved

Fusezion approved these changes Apr 22, 2023

View reviewed changes

src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java Outdated Show resolved Hide resolved

AyhamAl-Ali and others added 4 commits April 22, 2023 16:36

Update src/main/java/ch/njol/skript/expressions/ExprAnvilRepairCost.java

4c15eb7

Co-authored-by: Fusezion <fusezionstream@gmail.com>

Merge branch 'master' into feature/anvil-cost-expr

34a3f6d

Use registerDefault

d4aee4a

Remove unnecessary delta == null check

7d5d567

Merge branch 'master' into feature/anvil-cost-expr

c73d4a6

TheLimeGlass merged commit 1949a23 into SkriptLang:master Jun 24, 2023

Moderocky pushed a commit to Moderocky/Skript that referenced this pull request Sep 16, 2023

🚀 Add anvil repair cost expression (SkriptLang#4617)

f43731b

NotSoDelayed pushed a commit to NotSoDelayed/Skript that referenced this pull request Oct 30, 2023

🚀 Add anvil repair cost expression (SkriptLang#4617)

ba14fcb

Uh oh!

🚀 Add anvil repair cost expression #4617

🚀 Add anvil repair cost expression #4617

Uh oh!

Conversation

AyhamAl-Ali commented Feb 21, 2022

Description

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheLimeGlass commented Oct 26, 2022

Uh oh!

AyhamAl-Ali commented Oct 26, 2022

Uh oh!

TheLimeGlass commented Oct 26, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheLimeGlass commented May 4, 2023

Uh oh!

Uh oh!