Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve some errors and exceptions #4243

Merged
merged 12 commits into from
Jul 15, 2022

Conversation

TPGamesNL
Copy link
Member

@TPGamesNL TPGamesNL commented Aug 1, 2021

Description

  • Fix code like add awdwadwa to {_x} not giving the proper error
  • Improve hook loading exception handling
  • Improve variable serialization exception handling
  • Improve 'no class info found for ...' errors by including pattern and element class
  • Remove a wrongful assert

Target Minecraft Versions: any
Requirements: none
Related Issues: #4224 (non-fixing), #4234

@TPGamesNL TPGamesNL added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Aug 1, 2021
@TPGamesNL TPGamesNL mentioned this pull request Aug 1, 2021
1 task
@TPGamesNL TPGamesNL marked this pull request as draft March 1, 2022 18:03
@TPGamesNL TPGamesNL marked this pull request as ready for review March 6, 2022 15:56
@TPGamesNL TPGamesNL requested a review from APickledWalrus March 6, 2022 15:56
@TheLimeGlass
Copy link
Contributor

Can this be merged soon? I actually use this for error checking, it's helpful. @APickledWalrus

@TheLimeGlass
Copy link
Contributor

TheLimeGlass commented Jun 7, 2022

Skript.zip
Here is a compiled jar. It's zipped so I can upload it here (GitHub doesn't support .jar) for anyone that wants to help test this, or are too lazy to compile and build :P

@TheLimeGlass
Copy link
Contributor

TheLimeGlass commented Jun 7, 2022

I did have an error where it printed the same package location and same syntax for two different syntaxes both with incorrect classinfos expressions, maybe the local variable is not getting reset on loop somewhere?

Also I don't know if this is possible without some reflection, but it would be nice to document in the error where the calling code location for the .register is.

@TPGamesNL TPGamesNL merged commit 0e91c2e into SkriptLang:master Jul 15, 2022
@TPGamesNL TPGamesNL deleted the fix/error-stuff branch July 15, 2022 13:27
ALOBugTea pushed a commit to ALOBugTea/Skript that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants