Fix damaging items #2836
Merged
Fix damaging items #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensku
force-pushed
the
feature/2755-tool-damage
branch
from
e8b72fe to
f46308f
Compare
|
Accidentally included commits from other PRs, force pushed to fix this. |
ShaneBeee
approved these changes
Feb 29, 2020
There was a problem hiding this comment.
Tested last night with the script provided in the issue, to double check this was still an issue.
I got the stack trace error as described.
Tested today with this build, using the script provided in the issue and it works without stack trace errors :)
Looks all good to me 👍
ShaneBeee
added
the
bug
Whimsyturtle
approved these changes
Mar 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Damaging items would sometimes cause exceptions to be thrown.
Target Minecraft Versions: any
Requirements: none
Related Issues: #2755