Update README to use JitPack for addons #1446
Conversation
| maven { | ||
| url 'https://raw.githubusercontent.com/bensku/mvn-repo/master' | ||
| First, you need to add the JitPack repository at the **END** of all your repositories. Skript is not available in Maven Central. | ||
| ```gradle |
There was a problem hiding this comment.
Just put the repository declaration here and mention that it belongs to the repositories block.
If that seems too vague for you, just link them to the Gradle user guide since they should know where it goes already.
There was a problem hiding this comment.
JitPack recommends adding its repository at the end which is why I included that instruction.
Note: when using multiple repositories in build.gradle it is recommended to add JitPack at the end. Gradle will go through all repositories in order until it finds a dependency.
There was a problem hiding this comment.
Jitpack can be quite slow at times. If other repo can be used, that is probably a good idea.
There was a problem hiding this comment.
From my experience the speed of JitPack has been fine. The main issues I see with the current GitHub Repo as a Maven Repo is the extra work required to keep it up to date. Using JitPack removes that extra work, allowing addon developers to always use the latest version of Skript to build.
There was a problem hiding this comment.
Personally, Jitpack has never been slow to me, and I use it frequently. We're better off just merging this (thing that I already did) and change it if someone happens to have this issue.
Nicofisi
added
the
enhancement
|
Thanks for the contribution! |
Target Minecraft versions: N/A
Requirements: N/A
Related issues: N/A
Description:
This is an update to the README in order to move addon developers away from using the GitHub Maven repo and to instead use JitPack. Right now the GitHub Maven repo requires manual updates and doesn't have dev37. Changing to JitPack will remove the need for manual updates and will instead automatically update.