-
-
Notifications
You must be signed in to change notification settings - Fork 415
Closed
Labels
bugAn issue that needs to be fixed. Alternatively, a PR fixing an issue.An issue that needs to be fixed. Alternatively, a PR fixing an issue.completedThe issue has been fully resolved and the change will be in the next Skript update.The issue has been fully resolved and the change will be in the next Skript update.priority: mediumIssues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Description
Skript/Server Version
> sk info
[14:20:01 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[14:20:01 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[14:20:01 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[14:20:01 INFO]: [Skript] Server Version: 1.21.6-pre4-DEV-569c323 (MC: 1.21.6 Pre-Release 4)
[14:20:01 INFO]: [Skript] Skript Version: 2.11.2 (skriptlang-github)
[14:20:01 INFO]: [Skript] Installed Skript Addons:
[14:20:01 INFO]: [Skript] - SkNMS v1.2.1-1.21.6 (https://github.com/ShaneBeee/SkNMS)
[14:20:01 INFO]: [Skript] - SkBee v3.11.3 (https://github.com/ShaneBeee/SkBee)
[14:20:01 INFO]: [Skript] - skript-reflect v2.6 (https://github.com/SkriptLang/skript-reflect)
[14:20:01 INFO]: [Skript] Installed dependencies: NoneBug Description
The GameRule Value expression has a few issues:
-
isSingle returns false = It should return whether the input worlds are single, since getting the game rule of a single world should return single.
-
The change effect blindly sets the value to whatever you pass thru.
Example:
If I set thespawnChunkRadiusgame rule to 1.5, I get a warning in consoleFailed to parse integer integer
if I set that same game rule to true, I get a warning in consoleFailed to parse integer true
These should be checked before attempting to set the game rule.
Also, if passing in a number,Number#intValueshould be used.
Expected Behavior
-
isSingle should return properly based on world[s] input
-
When setting a game rule, the value used should be properly handled.
Steps to Reproduce
- Code:
set {_var} to gamerule doWeatherCycle of world of player
error:
[14:26:52 ERROR]: Error in: set {_var} to gamerule doWeatherCycle of world of player
[14:26:52 INFO]: {_var} can only be set to one object, not more
- Code:
set gamerule spawnChunkRadius of world "world" to 1.5
Error/Warning:
[14:28:03 WARN]: Failed to parse integer 1.5
Errors or Screenshots
No response
Other
No response
Agreement
- I have read the guidelines above and affirm I am following them with this report.
Metadata
Metadata
Assignees
Labels
bugAn issue that needs to be fixed. Alternatively, a PR fixing an issue.An issue that needs to be fixed. Alternatively, a PR fixing an issue.completedThe issue has been fully resolved and the change will be in the next Skript update.The issue has been fully resolved and the change will be in the next Skript update.priority: mediumIssues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Type
Projects
Status
Done - Released