Skip to content

Test issue: assertion can fail during variables (de-)serialisation test but tests report as successful. #7456

Open
@Moderocky

Description

@Moderocky

Skript/Server Version

2.10.0

Bug Description

There's a test that saves all the variables and loads them again and checks they're equal (to make sure serialisation is working).
I noticed when I had a bad serialiser for one type that the tests still report passed even if this throws an assertion error.

(Note: the serializer is fixed in #7455.)

Expected Behavior

The errors should constitute a failure rather than just being printed and buried in the log.

Steps to Reproduce

Run the tests.

Errors or Screenshots

Image Image Image

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugAn issue that needs to be fixed. Alternatively, a PR fixing an issue.housekeepingHousekeeping-related issue or task.unit testingFor issues/PRs related to the Skript unit testing system.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions