%direction% %location% will actually modify the location

[JohnHeikens]

Skript/Server Version

[Wed 21:13:46 INFO ] [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
  [Wed 21:13:46 INFO ] [Skript] Skript's documentation can be found here: https://skriptlang.github.io/Skript
  [Wed 21:13:46 INFO ] [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
  [Wed 21:13:46 INFO ] [Skript] Server Version: git-Paper-411 (MC: 1.17.1)
  [Wed 21:13:46 INFO ] [Skript] Skript Version: 2.6.4
  [Wed 21:13:46 INFO ] [Skript] Installed Skript Addons: 
  [Wed 21:13:46 INFO ] [Skript]  - AdvancementsAddon v1.0.0
  [Wed 21:13:46 INFO ] [Skript]  - Skacket v1.0.13
  [Wed 21:13:46 INFO ] [Skript]  - SkUniversal v2.13
  [Wed 21:13:46 INFO ] [Skript]  - DiSky v4.6.0
  [Wed 21:13:46 INFO ] [Skript]  - skUtilities v0.9.2 (https://tim740.github.io/)
  [Wed 21:13:46 INFO ] [Skript]  - skript-reflect v2.3 (https://github.com/TPGamesNL/skript-reflect)
  [Wed 21:13:46 INFO ] [Skript]  - skript-db v1.3.6
  [Wed 21:13:46 INFO ] [Skript]  - skRayFall v1.9.27 (https://sk.rayfall.net/)
  [Wed 21:13:46 INFO ] [Skript]  - SkQuery v4.1.7
  [Wed 21:13:46 INFO ] [Skript]  - SkBee v1.15.1 (https://github.com/ShaneBeee/SkBee)
  [Wed 21:13:46 INFO ] [Skript]  - WolvSK v1.7.2
  [Wed 21:13:46 INFO ] [Skript]  - RediSkript v1.3.6-SNAPSHOT
  [Wed 21:13:46 INFO ] [Skript] Installed dependencies: 
  [Wed 21:13:46 INFO ] [Skript]  - SQLibrary v7.1
  [Wed 21:13:46 INFO ] [Skript]  - Vault v1.7.3-b131
  [Wed 21:13:46 INFO ] [Skript]  - WorldGuard v7.0.6+1cff55f

Bug Description

when evaluating %direction% %location% (for example 'the block above expr-1'), expr-1 will actually get modified. when expr-q is queried after, it will have the result of the expression as value instead of it's original value.

Expected Behavior

expr-1 should not get modified at all when doing any get expressions on it.

Steps to Reproduce

condition test %location%:
    check:
        senddebug "loc1: %expr-1% -> below: %block below expr-1%" #expr-1 is modified here (the 'blow below expr-1' modifies it)
        
        senddebug "loc2: %expr-1% -> below: %block below expr-1%"

Errors or Screenshots

Other

No response

Agreement

• I have read the guidelines above and affirm I am following them with this report.

[TheLimeGlass]

Potentially what happened here #5319

I cannot reproduce on 2.6.4 on every version and I also cannot reproduce on Skript 2.7-dev (master)
Can you provide us with what you're inputting into the %location% expression in the skript-reflect syntax.

This is my test script that passes

test "location modify":
	set {_location} to location(-10.4, 100.6, 0.7, world "world")
	set {_clone} to {_location}
	assert {_clone} is {_location} with "locations were not the same"
	set {_unused} to block below {_location}
	assert {_clone} is {_location} with "locations were not the same 2"
	set {_unused} to "%block below {_location}% and %{_clone}%"
	assert {_clone} is {_location} with "locations were not the same 3"
	assert {_clone} is location(-10.4, 100.6, 0.7, world "world") with "locations were not the same 4"
	assert {_location} is location(-10.4, 100.6, 0.7, world "world") with "locations were not the same 5"
	assert location of block below {_location} is location of block below location(-10.4, 100.6, 0.7, world "world") with "locations were not the same 6"
	assert location of block below {_clone} is location of block below {_location} with "locations were not the same 7"
	assert "%location of {_clone}%" is "%location of {_location}%" with "locations were not the same 8"

[JohnHeikens]

hmm so it might be a skript-reflect issue, where it only affects 'expr-#'.

condition testcond %location%:
    check:
        #expr-1 is 0,0,0,"world"
        senddebug "loc1: %expr-1% -> below: %block below expr-1%" #expr-1 is modified here (the 'blow below expr-1' modifies it)
        #expr-1 is 0,-1,0,"world"
        senddebug "loc2: %expr-1% -> below: %block below expr-1%"
        #expr-1 is 0,-2,0,"world"
        continue


effect testeff %location%:
    trigger:
        #expr-1 is 0,0,0,"world"
        senddebug "loc1: %expr-1% -> below: %block below expr-1%" #expr-1 is modified here (the 'blow below expr-1' modifies it)
        #expr-1 is 0,-1,0,"world"
        senddebug "loc2: %expr-1% -> below: %block below expr-1%"
        #expr-1 is 0,-2,0,"world"
        
effect testeff2 %location%:
    trigger:
        set {_clone} to expr-1
        set {_unused} to block below expr-1
        assert expr-1 is {_clone} with "%expr-1% is not %{_clone}%"

command /testloc:
    trigger:
        senddebug "&atesting testeff"
        testeff location(0,0,0, "world")#modifies location
        senddebug "&ctesting testeff2"
        testeff2 location(0,0,0, "world")
        senddebug "&etesting testcond"
        if testcond location(0,0,0, "world"):#modifies location
            #this test passes on our server too
            set {_location} to location(-10.4, 100.6, 0.7, world "world")
            set {_clone} to {_location}
            assert {_clone} is {_location} with "locations were not the same"
            set {_unused} to block below {_location}#modifies location
            assert {_clone} is {_location} with "locations were not the same 2"
            set {_unused} to "%block below {_location}% and %{_clone}%"
            assert {_clone} is {_location} with "locations were not the same 3"
            assert {_clone} is location(-10.4, 100.6, 0.7, world "world") with "locations were not the same 4"
            assert {_location} is location(-10.4, 100.6, 0.7, world "world") with "locations were not the same 5"
            assert location of block below {_location} is location of block below location(-10.4, 100.6, 0.7, world "world") with "locations were not the same 6"
            assert location of block below {_clone} is location of block below {_location} with "locations were not the same 7"
            assert "%location of {_clone}%" is "%location of {_location}%" with "locations were not the same 8"

full output on my server:



all assertions pass except the one in testeff2 and testeff and testcond both modify the location.
senddebug is an effect which reduces 'send %expr-1% to "JohnHeikens" parsed as player' to a few words and should not be able to modify anything.
the screenshots overlap a bit on purpose.