Remove personal information from log entries - Recruitment #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasanthaKasirajan3008
requested review from
chrisjensenuk,
DevenKShah and
shomavg
as code owners
shomavg
approved these changes
Oct 18, 2019
DevenKShah
reviewed
Oct 21, 2019
| @@ -74,7 +74,7 @@ public async Task Run(CommunicationMessageIdentifier commMsgId) | |||
|
|
|||
| public async Task SendEmail(CommunicationMessage request) | |||
| { | |||
| _logger.LogInformation($"Trying to send message of type {request.RequestType} to {request.Recipient.Email}"); | |||
| _logger.LogInformation($"Trying to send message of type {request.RequestType}"); | |||
There was a problem hiding this comment.
This actually kills the purpose of the log. Instead can we trim the domain from the email so that this log entry makes any sense. You can create an extension method to trim everything after @ symbol in the email.
| @@ -50,7 +50,7 @@ public async Task Handle(GeocodeVacancyCommand message, CancellationToken cancel | |||
|
|
|||
| private Task<Geocode> GeocodePostcodeAsync(Vacancy vacancy) | |||
| { | |||
| _logger.LogInformation("Attempting to geocode postcode:'{postcode}' for vacancyId:'{vacancyId}'", vacancy.EmployerLocation.Postcode, vacancy.Id); | |||
| _logger.LogInformation("Attempting to geocode for vacancyId:'{vacancyId}'", vacancy.Id); | |||
There was a problem hiding this comment.
While we are printing postcode here... but it has no association with any individual... so postcode in itself shouldn't be an issue?
… back Postcode changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.