Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ER-1534 profanity check #832

Merged
merged 9 commits into from
Sep 27, 2019
Merged

ER-1534 profanity check #832

merged 9 commits into from
Sep 27, 2019

Conversation

shomavg
Copy link
Contributor

@shomavg shomavg commented Sep 20, 2019

No description provided.

@shomavg shomavg marked this pull request as ready for review September 24, 2019 11:44
chrisjensenuk
chrisjensenuk reviewed Sep 25, 2019
View reviewed changes
Copy link
Contributor

@chrisjensenuk chrisjensenuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed - some unit tests around the profanity property validator would be helpful

@shomavg shomavg merged commit 5534169 into master Sep 27, 2019
@shomavg shomavg deleted the ER-1534_ProfanityCheck branch September 27, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisjensenuk chrisjensenuk chrisjensenuk left review comments

@sachpatel sachpatel sachpatel approved these changes

@DevenKShah DevenKShah Awaiting requested review from DevenKShah

@mgwilliam mgwilliam Awaiting requested review from mgwilliam

@mrpmorris mrpmorris Awaiting requested review from mrpmorris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shomavg @chrisjensenuk @sachpatel