ER-1515 Rename ProgrammeLevel to ApprenticeshipLevel +semver: minor #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrpmorris
requested review from
chrisjensenuk,
DevenKShah,
mgwilliam,
sachpatel and
shomavg
as code owners
mrpmorris
changed the title
shomavg
reviewed
Sep 6, 2019
| return false; | ||
| } | ||
|
|
||
| //TODO: PeteM - RemapFromEducationLevel |
sachpatel
reviewed
Sep 6, 2019
| @@ -6,7 +6,7 @@ namespace Esfa.Recruit.Employer.Web.ViewModels.Part1.Training | |||
| public class ConfirmTrainingViewModel | |||
| { | |||
| public string TrainingTitle { get; set; } | |||
| public ProgrammeLevel Level { get; set; } | |||
| public ApprenticeshipLevel Level { get; set; } | |||
There was a problem hiding this comment.
Can I suggest that the property be called ApprenticeshipLevel
| { | ||
| public static class ApprenticeshipLevelHelper | ||
| { | ||
| //TODO: PeteM - TryRemapFromEducationLevel |
| @@ -9,7 +9,7 @@ public interface IApprenticeshipProgramme | |||
| string Title { get; } | |||
| DateTime? EffectiveFrom { get; } | |||
| DateTime? EffectiveTo { get; } | |||
| ProgrammeLevel Level { get; } | |||
| ApprenticeshipLevel Level { get; } | |||
There was a problem hiding this comment.
If property name can be changed as well please to ApprenticeshipLevel
| @@ -33,7 +33,7 @@ internal class VacancySummaryDetails | |||
| public DurationUnit DurationUnit { get; set; } | |||
| public string TrainingTitle { get; set; } | |||
| public TrainingType TrainingType { get; set; } | |||
| public ProgrammeLevel TrainingLevel { get; set; } | |||
| public ApprenticeshipLevel TrainingLevel { get; set; } | |||
There was a problem hiding this comment.
Change name to ApprenticeshipLevel
| public void TryRemapFromInt_ShouldSucceedAndReturnHigher_WhenConvertingFromFoundation5() | ||
| { | ||
| bool success = ApprenticeshipLevelHelper.TryRemapFromInt(5, out ApprenticeshipLevel result); | ||
| success.Should().Be(true); |
There was a problem hiding this comment.
Thanks for using Fluent, just a tip .Be(true) can be replaced with BeTrue()
shomavg
reviewed
Nov 5, 2019
| @@ -114,7 +114,7 @@ private bool IsEditRequired(string fieldIdentifier) | |||
| }.Count(s => s == VacancyPreviewSectionState.Incomplete || s == VacancyPreviewSectionState.InvalidIncomplete); | |||
|
|
|||
| public string IncompleteRequiredSectionText => "section".ToQuantity(IncompleteRequiredSectionCount, ShowQuantityAs.None); | |||
| public ProgrammeLevel Level { get; set; } | |||
| public ApprenticeshipLevel Level { get; set; } | |||
There was a problem hiding this comment.
Can we keep the name consistent to ApprenticeshipLevel?
| @@ -114,7 +114,7 @@ public class VacancyPreviewViewModel : DisplayVacancyViewModel | |||
| public bool VacancyDescriptionRequiresEdit => IsEditRequired(FieldIdentifiers.VacancyDescription); | |||
| public bool WageRequiresEdit => IsEditRequired(FieldIdentifiers.Wage); | |||
| public bool WorkingWeekRequiresEdit => IsEditRequired(FieldIdentifiers.WorkingWeek); | |||
| public ProgrammeLevel Level { get; set; } | |||
| public ApprenticeshipLevel Level { get; set; } | |||
There was a problem hiding this comment.
Change name to ApprenticeshipLevel.
| @@ -121,6 +121,6 @@ private string GetFieldIdentifierCssClass(string fieldIdentifer) | |||
| { | |||
| return FieldIdentifiers.Single(f => f.FieldIdentifier == fieldIdentifer).FieldValueHasChanged ? CssFieldChanged : null; | |||
| } | |||
| public ProgrammeLevel Level { get; set; } | |||
| public ApprenticeshipLevel Level { get; set; } | |||
There was a problem hiding this comment.
Change name to ApprenticeshipLevel
| @@ -16,7 +16,7 @@ public class VacancySummaryViewModel | |||
| public string ProgrammeId { get; set; } | |||
| public string TrainingTitle { get; set; } | |||
| public TrainingType TrainingType { get; set; } | |||
| public ProgrammeLevel TrainingLevel { get; set; } | |||
| public ApprenticeshipLevel TrainingLevel { get; set; } | |||
There was a problem hiding this comment.
Change name to ApprenticeshipLevel
| @@ -25,7 +25,7 @@ public class VacancySummary | |||
| public DateTime? StartDate { get; set; } | |||
| public string TrainingTitle { get; set; } | |||
| public TrainingType TrainingType { get; set; } | |||
| public ProgrammeLevel TrainingLevel { get; set; } | |||
| public ApprenticeshipLevel TrainingLevel { get; set; } | |||
There was a problem hiding this comment.
Change name to ApprenticeshipLevel
| @@ -33,7 +33,7 @@ internal class VacancySummaryDetails | |||
| public DurationUnit DurationUnit { get; set; } | |||
| public string TrainingTitle { get; set; } | |||
| public TrainingType TrainingType { get; set; } | |||
| public ProgrammeLevel TrainingLevel { get; set; } | |||
| public ApprenticeshipLevel TrainingLevel { get; set; } | |||
There was a problem hiding this comment.
Change name to ApprenticeshipLevel
DevenKShah
force-pushed
the
ER-1515_RemoveProgrammeLevel
branch
from
e0c1f5f
to
b1b6d9d
Compare
DevenKShah
force-pushed
the
ER-1515_RemoveProgrammeLevel
branch
from
b1b6d9d
to
79fee60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.