ER-1374 📦⬆ - General sweep of safe package upgrades #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachpatel
requested review from
chrisjensenuk,
DevenKShah,
mgwilliam,
mrpmorris and
shomavg
as code owners
|
💥 |
sachpatel
force-pushed
the
maintenance/ER-1374_upgradeDepsJuly2019
branch
from
0590751
to
0d02f67
Compare
sachpatel
changed the title
|
So the one package ai did a major upgrade of expecting no breaking changes that were not documented I have reverted back so all the upgrades are safe. We will have to tackle upgrading Asp.Net FluentValidation sometime in the future. |
chrisjensenuk
approved these changes
Jul 11, 2019
sachpatel
force-pushed
the
maintenance/ER-1374_upgradeDepsJuly2019
branch
from
0d02f67
to
1dde165
Compare
sachpatel
force-pushed
the
maintenance/ER-1374_upgradeDepsJuly2019
branch
from
1dde165
to
fd2c1d7
Compare
DevenKShah
force-pushed
the
maintenance/ER-1374_upgradeDepsJuly2019
branch
from
fd2c1d7
to
daf8daa
Compare
DevenKShah
force-pushed
the
maintenance/ER-1374_upgradeDepsJuly2019
branch
from
9cd7075
to
f5570e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have put particular regression test points relating to this upgrade in the JIRA ticket https://skillsfundingagency.atlassian.net/browse/ER-1374