This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
FC-76 training provider search #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added service call for PostCode IO to get the lat and long for a given postcode. Add configuration setting and also HttpClient implementation with interface
Implemented the GetProvidersByPostCodeAndStandard into the provider repository and also the providers controller.
| @@ -131,5 +132,13 @@ public async Task<IEnumerable<Standard>> GetStandardsByIdAsync(List<string> ids, | |||
| return await RequestAndDeserialiseAsync<IEnumerable<Standard>>(request); | |||
| } | |||
| } | |||
|
|
|||
| public async Task<IEnumerable<StandardProvider>> GetProvidersByStandardAndLocation(int standardCode, string postCode, int page = 1) | |||
There was a problem hiding this comment.
Could you please add "Async" to the name and create a synchronous method as well?
Changed name of method and added sync call
|
|
||
| public IEnumerable<StandardProvider> GetProvidersByStandardAndLocation(int standardCode, string postCode,int page = 1) | ||
| { | ||
| return GetProvidersByStandardAndLocationAsync(standardCode, postCode, page).Result; |
There was a problem hiding this comment.
why not to use RequestAndDeserialise as we have at the rest of the methods?
JoseviAgullo
approved these changes
Nov 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented end point for getting training providers by postcode and standard