Conversation
…nd update event handling
pzocchi
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the RL input components to use Shoelace’s React component wrappers instead of custom JSX element declarations, and updates event handling to use the new Shoelace event names and types. It also improves type safety, adds new props for greater flexibility, and updates Storybook stories for better interactivity and demonstration.
Component refactoring and Shoelace integration:
SlInput,SlDropdown,SlIconButton) inRLInput,RLNumberInput, andRLDatePickercomponents, improving type safety and React compatibility. [1] [2] [3]onSlChange,onSlBlur) andCustomEventtypes, and ensures validation is triggered on change. [1] [2] [3]Prop and type improvements:
RLInputandRLNumberInput(e.g.,min,max,step,noSpinButtons,className,onClick, more input modes), and updates their TypeScript types for more flexibility and correctness. [1] [2] [3]Storybook updates:
RLInputandRLNumberInputto use local state for value management and demonstrate controlled usage, making examples more interactive and realistic. [1] [2] [3] [4]Code cleanup:
Consistency and usability improvements: