Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local linting to development workflow #460

Closed
3 tasks
fredrikhgrelland opened this issue Jan 19, 2021 · 0 comments · Fixed by #459
Closed
3 tasks

Add local linting to development workflow #460

fredrikhgrelland opened this issue Jan 19, 2021 · 0 comments · Fixed by #459
Assignees
@fredrikhgrelland
Labels
theme/ci Related to build, test, and release pipeline theme/test Related to testing theme/ux Related to the user experience of the box or template type/documentation Improvements or additions to documentation type/enhancement New feature or request
Milestone
0.10.0

Comments

@fredrikhgrelland
Copy link
Contributor

Feature description

We have opted to use github/superlinter in order to maintain better code quality in this project.
Linting needs to be available to developers before PRs are filed.

Why is it needed?

Currently, linters are used as a QA gate in Pull requests. You will not experience linter warnings/errors before being rejected on the PR. This is bad affordance and must be changed

Suggestion(s)/solution(s) [Optional]

Add make lint to this project. It should run the same linters as GitHub Actions in PR.

Definition of done

Linting can be performed in development and will not fail in PR.

Checklist (after created issue)

  • Added label(s)
  • Added to project
  • Added to milestone
@fredrikhgrelland fredrikhgrelland added type/documentation Improvements or additions to documentation type/enhancement New feature or request theme/test Related to testing theme/ci Related to build, test, and release pipeline theme/ux Related to the user experience of the box or template labels Jan 19, 2021
@fredrikhgrelland fredrikhgrelland added this to the 0.10.0 milestone Jan 19, 2021
@fredrikhgrelland fredrikhgrelland self-assigned this Jan 19, 2021
fredrikhgrelland pushed a commit that referenced this issue Jan 19, 2021
Run linters locally - fix errors found #460
44d3579
fredrikhgrelland pushed a commit that referenced this issue Jan 19, 2021
Run linters locally - fix errors found #460
9e7b5b0
@fredrikhgrelland fredrikhgrelland linked a pull request Jan 19, 2021 that will close this issue
Fix mac install #459
Merged
5 tasks
fredrikhgrelland pushed a commit that referenced this issue Jan 19, 2021
Run linters locally - fix errors found #460
81aed8b
fredrikhgrelland pushed a commit that referenced this issue Jan 20, 2021
@fredrikhgrelland
Run linters locally - fix errors found #460
f649a38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredrikhgrelland fredrikhgrelland

Labels
theme/ci Related to build, test, and release pipeline theme/test Related to testing theme/ux Related to the user experience of the box or template type/documentation Improvements or additions to documentation type/enhancement New feature or request
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Fix mac install Skatteetaten/vagrant-hashistack
1 participant
@fredrikhgrelland