-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc linedensity interpolation #50
Feature/sc linedensity interpolation #50
Conversation
... to have the same layout in terms of number of particles as in SpaceChargeBunched
…le.. .. in view of the upgrade to arbitrary generalised Gaussian bunch profiles.
Here's a test for the new interpolating class: |
Just as a remark, I've added It'd probably be nicer (for compute time) to avoid recomputing the bins for the interpolation at each track call, but I avoided touching the instantiation part (for precomputing and storing at |
e492a14
to
1e4875d
Compare
... SpaceChargeCoasting to new interface with number_of_particles and circumference.
The latest commit should solve any test errors and also bring the examples in line. Now that |
...default options in loader_mad.py .
Pr37and50
Updated with aoeftiger#2 . Still needs to be adapted to the final layout and naming conventions (along with the still missing implementation of the q-Gaussian algorithm as in STL by @martinschwinzerl ) following the SixTrackLib counterpart SixTrack/sixtracklib#132 . |
- add attribute for the interpolation method (0=linear, 1=cubic spline) - implement tracking to use the interpolation method - add fallback if no legal interpolation method is available -> this is consitent with the behaviour of SixTrackLib
…terpolation Feature/sc linedensity interpolation
…lation' into feature/sc-linedensity-interpolation
…terpolation bumps version number
Updating typo in y coordinate unit with shifted parenthesis
... which are passed on to the created Particles instance, such that closed orbits w.r.t. to different mass and charge can be found.
--> adding Roman's and Kosta's new features
... w.r.t. longitudinal parameter in functions for setting up SC classes
... such that mass and charge can be changed to other than proton default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved
Adding a new space charge class with bunch profile interpolation (e.g. for double harmonics and anything else).
Up for discussion 😄
On another note, this patch introduces the new naming and refactoring of space charge classes discussed with @hannes-bartosik and @martinschwinzerl (cf. email 6.5.2020):
SpaceChargeCoasting
attributes are adapted toSpaceChargeBunched
withline_density
replaced bynumber_of_particles
and an additionalcircumference
attribute; thetrack
method has been adjusted correspondinglySpaceChargeBunched
becomesSpaceChargeQGaussianProfile
and sports two new attributes (q and b factor for q-Gaussian which by default are 1.0 for the standard Gaussian) --> this class has yet to be extended to support q,b != 1due to the renaming, the automated tests will have to be adapted, otherwise they throw: