Merged
Conversation
Member
Author
|
@iamcarbon in #872, everything else seems C# 8 related to me. Am I missing something? |
Member
|
Very odd. I thought #872 updated appveyor.yml to ensure the builds happen in VS2019. I'm not sure how it builds now while targeting C#8. |
JimBobSquarePants
approved these changes
Apr 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
==========================================
+ Coverage 88.97% 88.98% +0.01%
==========================================
Files 1018 1018
Lines 44579 44537 -42
Branches 3234 3220 -14
==========================================
- Hits 39663 39632 -31
+ Misses 4195 4194 -1
+ Partials 721 711 -10
Continue to review full report at Codecov.
|
Contributor
|
@JimBobSquarePants We only needed an SDK updated target C# 8.0 on AppVeyor. They updated the SDK in their standard image. |
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Minimalistic subset of #872 to unblock our work.