Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Remove the hardcoded subsampling initializer from JpegComponent. Our decoder can handle the interleaved for CMYK and YccK jpegs. Fix #817

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #834 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #834     +/-   ##
=========================================
- Coverage   88.84%   88.75%   -0.1%     
=========================================
  Files        1015     1015             
  Lines       44167    44165      -2     
  Branches     3181     3180      -1     
=========================================
- Hits        39241    39199     -42     
- Misses       4201     4206      +5     
- Partials      725      760     +35
Impacted Files Coverage Δ
...Sharp.Tests/Formats/Jpg/JpegDecoderTests.Images.cs 100% <100%> (ø) ⬆️
...p/Formats/Jpeg/Components/Decoder/JpegComponent.cs 97.61% <100%> (-0.16%) ⬇️
tests/ImageSharp.Tests/TestImages.cs 100% <100%> (ø) ⬆️
...xelFormats/PixelOperations{TPixel}.PixelBenders.cs 89.34% <0%> (-9.84%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 88.29% <0%> (-5.32%) ⬇️
src/ImageSharp/Common/Helpers/ImageMaths.cs 82.05% <0%> (-5.13%) ⬇️
.../Processing/Processors/Transforms/CropProcessor.cs 96% <0%> (-4%) ⬇️
...ocessing/Processors/Dithering/ErrorDiffuserBase.cs 93.75% <0%> (-3.13%) ⬇️
...rs/Normalization/HistogramEqualizationProcessor.cs 97.5% <0%> (-2.5%) ⬇️
...eSharp.Tests/IO/DoubleBufferedStreamReaderTests.cs 97.61% <0%> (-2.39%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0b012...6fd7f4f. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #834 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
- Coverage   88.84%   88.84%   -0.01%     
==========================================
  Files        1015     1015              
  Lines       44169    44167       -2     
  Branches     3181     3180       -1     
==========================================
- Hits        39243    39241       -2     
  Misses       4201     4201              
  Partials      725      725
Impacted Files Coverage Δ
...Sharp.Tests/Formats/Jpg/JpegDecoderTests.Images.cs 100% <100%> (ø) ⬆️
...p/Formats/Jpeg/Components/Decoder/JpegComponent.cs 97.61% <100%> (-0.16%) ⬇️
tests/ImageSharp.Tests/TestImages.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff31b5f...cc29264. Read the comment docs.

@JimBobSquarePants
Copy link
Member Author

I'm gonna go ahead and merge this. Coverage is 100% and all tests pass.

@JimBobSquarePants JimBobSquarePants merged commit 5a9b84e into master Feb 15, 2019
@JimBobSquarePants JimBobSquarePants deleted the js/fix-817 branch February 15, 2019 11:02
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants