Remove hardcoded subsampling.#834
Merged
JimBobSquarePants merged 2 commits intomasterfrom Feb 15, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
=========================================
- Coverage 88.84% 88.75% -0.1%
=========================================
Files 1015 1015
Lines 44167 44165 -2
Branches 3181 3180 -1
=========================================
- Hits 39241 39199 -42
- Misses 4201 4206 +5
- Partials 725 760 +35
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
==========================================
- Coverage 88.84% 88.84% -0.01%
==========================================
Files 1015 1015
Lines 44169 44167 -2
Branches 3181 3180 -1
==========================================
- Hits 39243 39241 -2
Misses 4201 4201
Partials 725 725
Continue to review full report at Codecov.
|
Member
Author
|
I'm gonna go ahead and merge this. Coverage is 100% and all tests pass. |
antonfirsov
pushed a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Remove the hardcoded subsampling initializer from
JpegComponent. Our decoder can handle the interleaved for CMYK and YccK jpegs. Fix #817