Skip to content

Update System.* deps to 4.5.0-rc1 #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 9, 2018
Merged

Update System.* deps to 4.5.0-rc1 #560

merged 5 commits into from
May 9, 2018

Conversation

@iamcarbon
Copy link
Contributor

@iamcarbon iamcarbon commented May 7, 2018

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Updates System.* deps to 4.5.0-rc1. there were no breaking changes. The API surface for System.Memory should finally be stable!

@codecov
Copy link

codecov bot commented May 7, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@1797fee). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #560   +/-   ##
=========================================
  Coverage          ?   88.62%           
=========================================
  Files             ?      843           
  Lines             ?    35518           
  Branches          ?     2584           
=========================================
  Hits              ?    31478           
  Misses            ?     3263           
  Partials          ?      777

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1797fee...02dde9d. Read the comment docs.

@iamcarbon
Copy link
Contributor Author

iamcarbon commented May 7, 2018

Notable: All tests pass on .NETCORE 2.1.

antonfirsov
antonfirsov reviewed May 7, 2018
View reviewed changes
tests/ImageSharp.Sandbox46/ImageSharp.Sandbox46.csproj
<Reference Include="Microsoft.CSharp" />
</ItemGroup>
<ItemGroup>
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
Copy link
Member

@antonfirsov antonfirsov May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition is accidental I guess.

Copy link
Contributor Author

@iamcarbon iamcarbon May 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS used to create these service references for test projects. It hasn't for a few releases now. Are there any legacy tools that still need this? cc: @antonfirsov

Copy link
Member

@JimBobSquarePants JimBobSquarePants May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so as far as I'm aware.

Copy link
Contributor Author

@iamcarbon iamcarbon May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimBobSquarePants Removed the System.Numerics.Vectors reference all together. I think the NuGET package just type forwards everything to the builtins anyhow.

Copy link
Member

@JimBobSquarePants JimBobSquarePants May 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamcarbon Good man. 👍

@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented May 8, 2018

Ooft! This is great! We can now finally expose the memory API's we need for interop and per row augmentation.

JimBobSquarePants
JimBobSquarePants reviewed May 8, 2018
View reviewed changes
src/ImageSharp/ImageSharp.csproj Outdated
<PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="4.5.0-preview2-26406-04" />
<PackageReference Include="System.Memory" Version="4.5.0-rc1" />
<PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="4.5.0-rc1" />
<PackageReference Include="System.Numerics.Vectors" Version="4.5.0-rc1" />
Copy link
Member

@JimBobSquarePants JimBobSquarePants May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should update Core and let this dependency float through implicitly.

@antonfirsov antonfirsov mentioned this pull request May 8, 2018
Closed
@JimBobSquarePants JimBobSquarePants merged commit 1d9de11 into SixLabors:master May 9, 2018
@iamcarbon iamcarbon deleted the memory-rc1 branch May 9, 2018 00:54
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
@JimBobSquarePants
Merge pull request SixLabors#560 from carbon/memory-rc1
cb75a34 
Update System.* deps to 4.5.0-rc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

@antonfirsov antonfirsov antonfirsov left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iamcarbon @JimBobSquarePants @antonfirsov