Disposing data chunk instead of explicit returning it to ArrayPool in PngDecoderCore.Identify#534
Merged
JimBobSquarePants merged 2 commits intoSixLabors:masterfrom Apr 18, 2018
Conversation
Member
|
Hi @denisivan0v Good catch! I'll get this merged once the CI finished 👍 |
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=========================================
- Coverage 87.21% 87.2% -0.02%
=========================================
Files 842 842
Lines 35452 35451 -1
Branches 2627 2627
=========================================
- Hits 30920 30914 -6
- Misses 3763 3767 +4
- Partials 769 770 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
Many thanks @JimBobSquarePants! 🎉 |
Member
|
No worries! Thanks for the PR! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The new
Image.IdentifyAPI was introduced in #292. In #475 memory management was significantly improved, but there is still a case forpngformat whenArrayPoolis used directly when callingImage.Identify, not withIManagedByteBufferAPI.This leads to the issue when
ArgumentExceptionis throwing inArrayPool.Returnmethod with this message:This PR fixes this problem.