Enable Visual Studio code coverage

[olivif]

Visual Studio code coverage wasn't working for me due to some missing Shim dll so I fixed it - by adding MS codecoverage as a dependency.

I also added a runsettings file to make sure only the right dlls end up in the coverage. You will need to import this from Test - TestSettings - Select test settings file 😄

[JimBobSquarePants]

@dlemstra Over to you....

[dlemstra]

These changes seem to add another extra 4 minutes to our AppVeyor build. But we are building net451 and that should not affect this. Do you have any idea what could have caused this @olivif? Maybe it was just a one time delay?

[olivif]

Hmm that's odd. Let me have a look at the build logs, see if I can spot anything 😄 Nothing should add that much really, I can also trigger a couple more builds on this branch to see if it was a one off.

[olivif]

Ah OK I think I found something. On this particular build seems like we had trouble connecting to codecov the first time, so we retried. The retry seems to have a back off mechanism behind it so the time between retries kept expanding.

==> Uploading
    .url https://codecov.io
    .query job=JamesSouth%2Fimagesharp%2Fv1.0.0-alpha-000176&branch=master&slug=JimBobSquarePants%2FImageSharp&build=yh5eb877jbyk8fna&service=appveyor&pr=50&commit=cf1dd55e6f729ff1fc22e4378addcfcd0456169a&package=py2.0.5
    Pinging Codecov...
    Retrying... in 30s
    Pinging Codecov...
    Retrying... in 60s
    Pinging Codecov...
    Retrying... in 90s 

whereas on another build off of master I compared with

==> Uploading
    .url https://codecov.io
    .query package=py2.0.5&commit=d2669d09724ca82bd48b3763ca772343aa8baee1&slug=JimBobSquarePants%2FImageSharp&service=appveyor&job=JamesSouth%2Fimagesharp%2Fv1.0.0-alpha-000177&branch=master&build=np3weco8y2r48j5p
    Pinging Codecov...
    Uploading to S3...

I think it was intermittent but I would love to re-trigger the build on the PR a few times to make sure.

Do you know if I can retrigger a build without a new commit? 😄

[dlemstra]

I found something else. It looks like the tests did not complete properly:

Your build:

xUnit.net .NET CLI test runner (64-bit Desktop .NET win81-x64)
  Discovering: ImageSharp.Tests
  Discovered:  ImageSharp.Tests
  Starting:    ImageSharp.Tests

One of mine:

xUnit.net .NET CLI test runner (64-bit Desktop .NET win81-x64)
  Discovering: ImageSharp.Tests
  Discovered:  ImageSharp.Tests
  Starting:    ImageSharp.Tests
  Finished:    ImageSharp.Tests
=== TEST EXECUTION SUMMARY ===
   ImageSharp.Tests  Total: 353, Errors: 0, Failed: 0, Skipped: 0, Time: 436.371s

I don't know how you could trigger a build with a new commit. What I would do in this case would be doing is changing white space inside CodeCoverage.runsettings then do an 'amend commit' and force push that to your branch. I have done this myself a couple times in another project and that seems to trigger a new build.

[codecov-io]

Current coverage is 74.08% (diff: 100%)

Merging #50 into master will increase coverage by 0.01%

@@             master        #50   diff @@
==========================================
  Files           334        337     +3   
  Lines         17714      17787    +73   
  Methods        3331       3355    +24   
  Messages          0          0          
  Branches       2081       2093    +12   
==========================================
+ Hits          13121      13178    +57   
- Misses         4004       4019    +15   
- Partials        589        590     +1   

Powered by Codecov. Last update 4974053...c91ef7f

[dlemstra]

Seems like this was a one off. It looks like you added an extra commit to trigger the build. Are you going to reset your master to the previous commit or should I go ahead and merge this?

[olivif]

Yes, looks like the time is back to 8mins. I think you can merge this because the indentation was actually off, so the commit did something useful 😄 thanks for the help @dlemstra