Remove Unsafe usage from GifDecoderCore and optimize loops - #2851
Merged
Conversation
| Span<TPixel> row = imageFrame.PixelBuffer.DangerousGetRowSpan(writeY); | ||
|
|
||
| // Take the descriptorLeft..maxX slice of the row, so the loop can be simplified. | ||
| row = row[descriptorLeft..maxX]; |
Member
There was a problem hiding this comment.
This is so much neater. I'm sure there's other places we do bounds based looping in decoders like this.
JimBobSquarePants
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Originally wanted to straightly PR the idea in #2850, but felt like we need to do something about the high amount of unsafe code in
GifDecoderCorebefore touching anything there. By simply removing Unsafe, I noticed a minor perf drop. I managed compensate it by changing the inner loops so the JIT can remove bounds checks at least for one of the spans.Benchmarks