Normalize Animation Encoders - #2842
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 11 out of 26 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- tests/Directory.Build.targets: Language not supported
- tests/ImageSharp.Benchmarks/ImageSharp.Benchmarks.csproj: Language not supported
- src/ImageSharp/Formats/QuantizingImageEncoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/WebpEncoder.cs: Evaluated as low risk
- tests/ImageSharp.Benchmarks/Codecs/Webp/DecodeWebp.cs: Evaluated as low risk
- tests/ImageSharp.Benchmarks/Codecs/Tga/DecodeTga.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/WebpFrameMetadata.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/WebpEncoderCore.cs: Evaluated as low risk
- src/ImageSharp/Formats/FormatConnectingMetadata.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/Lossy/Vp8Encoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Gif/GifEncoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Png/PngEncoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/Lossless/Vp8LEncoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Webp/WebpAnimationDecoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Png/PngEncoderCore.cs: Evaluated as low risk
| int partitionSize = (int)Math.Ceiling((double)this.Images.Length / maxDegreeOfParallelism); | ||
|
|
||
| List<Task> tasks = new(); | ||
| List<Task> tasks = []; |
There was a problem hiding this comment.
The initialization of the tasks list is incorrect. It should be 'List tasks = new List();'.
Suggested change
| List<Task> tasks = []; | |
| List<Task> tasks = new List<Task>(); |
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Adds a couple of new interfaces and base classes to normalize configuration of encoders for formats that produce animation sequences.
Also