-
-
Notifications
You must be signed in to change notification settings - Fork 888
v3.1.x Fix 2758 #2759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.1.x Fix 2758 #2759
Conversation
Looks like it's breaking other gif use-cases? I plan to also take a look in the weekend and the add test images. For me File Explorer works on Win11 for the folder. |
5656e71
to
e4ba5d3
Compare
@antonfirsov My first attempt was bad as I misunderstood the problem. I've now refactored the LZW decoder to run row-by-row, so we only allocate enough bytes for a single row rather than the full buffer. In this case this brings down the allocation from 4GB to 64K. This should mean a massive win across the board. |
Prerequisites
Description
Fixes #2758
I cannot include the images in the tests as I was unable to open a FileExplorer instance containing them without crashing in my Windows 11 instance.Still not sure what's going on with the provided repo, but I have added the relevant test images and tests.