Skip to content

Conversation

@antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Jun 13, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Since dotnet/arcade#7443 and dotnet/arcade#7426 got merged, we just need to update RemoteExecutor to fix #1376.

Update: Looks like dotnet/arcade#7426 doesn't work with the legacy xunit console host we use for running 32 bit tests on .NET Framework, disabled the test for that case, will open an issue for the gap.

WIP:

  • Add a test for false positives (curious about current CI results)
  • Update RemoteExecutor version
  • Fix test failures

@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #1659 (255802c) into master (381dff8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1659   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files         816      816           
  Lines       35827    35827           
  Branches     4159     4159           
=======================================
  Hits        30193    30193           
  Misses       4819     4819           
  Partials      815      815           
Flag Coverage Δ
unittests 84.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381dff8...255802c. Read the comment docs.

@antonfirsov antonfirsov changed the title [WIP] Update RemoteExecutor Update RemoteExecutor Jun 13, 2021
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test coverage not reliable because of RemoteExecutor bug

3 participants