Skip to content

Enable resize tests on MacOs #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 22, 2020
Merged

Enable resize tests on MacOs #1434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
801e026
Enable resize tests
JimBobSquarePants Nov 20, 2020
2e3f3c1
Use doubles in ResizeHelper
JimBobSquarePants Nov 21, 2020
25d5e48
Revert "Use doubles in ResizeHelper"
JimBobSquarePants Nov 21, 2020
6e589e8
Use higher tolerance on macOS CI runs
JimBobSquarePants Nov 21, 2020
ecf05e2
Bump tolerance
JimBobSquarePants Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,3 +221,4 @@ artifacts/
# Tests
**/Images/ActualOutput
**/Images/ReferenceOutput
.DS_Store
6 changes: 2 additions & 4 deletions tests/ImageSharp.Tests/Processing/Processors/Transforms/ResizeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ public class ResizeTests
nameof(KnownResamplers.Lanczos5),
};

private static readonly ImageComparer ValidatorComparer = ImageComparer.TolerantPercentage(0.07F);
private static readonly ImageComparer ValidatorComparer =
ImageComparer.TolerantPercentage(TestEnvironment.IsOSX && TestEnvironment.RunsOnCI ? 0.26F : 0.07F);

[Fact]
public void Resize_PixelAgnostic()
Expand Down Expand Up @@ -355,7 +356,6 @@ public void Resize_WorksWithAllResamplers<TPixel>(
}

[Theory]
[PlatformSpecific(~TestPlatforms.OSX)]
[WithFileCollection(nameof(CommonTestImages), DefaultPixelType)]
public void ResizeFromSourceRectangle<TPixel>(TestImageProvider<TPixel> provider)
where TPixel : unmanaged, IPixel<TPixel>
Expand Down Expand Up @@ -438,7 +438,6 @@ public void ResizeWidthCannotKeepAspectKeepsOnePixel<TPixel>(TestImageProvider<T
}

[Theory]
[PlatformSpecific(~TestPlatforms.OSX)]
[WithFileCollection(nameof(CommonTestImages), DefaultPixelType)]
public void ResizeWithBoxPadMode<TPixel>(TestImageProvider<TPixel> provider)
where TPixel : unmanaged, IPixel<TPixel>
Expand Down Expand Up @@ -549,7 +548,6 @@ public void ResizeWithMinMode<TPixel>(TestImageProvider<TPixel> provider)
}

[Theory]
[PlatformSpecific(~TestPlatforms.OSX)]
[WithFileCollection(nameof(CommonTestImages), DefaultPixelType)]
public void ResizeWithPadMode<TPixel>(TestImageProvider<TPixel> provider)
where TPixel : unmanaged, IPixel<TPixel>
Expand Down
2 changes: 2 additions & 0 deletions tests/ImageSharp.Tests/TestUtilities/TestEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ internal static string GetReferenceOutputFileName(string actualOutputFileName) =

internal static bool IsLinux => RuntimeInformation.IsOSPlatform(OSPlatform.Linux);

internal static bool IsOSX => RuntimeInformation.IsOSPlatform(OSPlatform.OSX);

internal static bool IsMono => Type.GetType("Mono.Runtime") != null; // https://stackoverflow.com/a/721194

internal static bool IsWindows => RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
Expand Down